Skip to content

Commit e16d521

Browse files
committed
[MediaCCC] Apply changes in Extractors
Also remove usage of the conference logo as the banner of a conference, as it is a logo and not a banner.
1 parent 306068a commit e16d521

4 files changed

Lines changed: 31 additions & 16 deletions

File tree

extractor/src/main/java/org/schabi/newpipe/extractor/services/media_ccc/extractors/MediaCCCConferenceExtractor.java

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import org.schabi.newpipe.extractor.InfoItem;
88
import org.schabi.newpipe.extractor.ListExtractor;
99
import org.schabi.newpipe.extractor.MultiInfoItemsCollector;
10+
import org.schabi.newpipe.extractor.Image;
1011
import org.schabi.newpipe.extractor.Page;
1112
import org.schabi.newpipe.extractor.StreamingService;
1213
import org.schabi.newpipe.extractor.channel.ChannelExtractor;
@@ -21,10 +22,13 @@
2122
import org.schabi.newpipe.extractor.services.media_ccc.linkHandler.MediaCCCConferenceLinkHandlerFactory;
2223

2324
import java.io.IOException;
25+
import java.util.Collections;
2426
import java.util.List;
2527

2628
import javax.annotation.Nonnull;
2729

30+
import static org.schabi.newpipe.extractor.services.media_ccc.extractors.MediaCCCParsingHelper.getImageListFromLogoImageUrl;
31+
2832
public class MediaCCCConferenceExtractor extends ChannelExtractor {
2933
private JsonObject conferenceData;
3034

@@ -33,14 +37,16 @@ public MediaCCCConferenceExtractor(final StreamingService service,
3337
super(service, linkHandler);
3438
}
3539

40+
@Nonnull
3641
@Override
37-
public String getAvatarUrl() {
38-
return conferenceData.getString("logo_url");
42+
public List<Image> getAvatars() {
43+
return getImageListFromLogoImageUrl(conferenceData.getString("logo_url"));
3944
}
4045

46+
@Nonnull
4147
@Override
42-
public String getBannerUrl() {
43-
return conferenceData.getString("logo_url");
48+
public List<Image> getBanners() {
49+
return Collections.emptyList();
4450
}
4551

4652
@Override
@@ -68,9 +74,10 @@ public String getParentChannelUrl() {
6874
return "";
6975
}
7076

77+
@Nonnull
7178
@Override
72-
public String getParentChannelAvatarUrl() {
73-
return "";
79+
public List<Image> getParentChannelAvatars() {
80+
return Collections.emptyList();
7481
}
7582

7683
@Override

extractor/src/main/java/org/schabi/newpipe/extractor/services/media_ccc/extractors/MediaCCCLiveStreamExtractor.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
package org.schabi.newpipe.extractor.services.media_ccc.extractors;
22

3+
import static org.schabi.newpipe.extractor.services.media_ccc.extractors.MediaCCCParsingHelper.getThumbnailsFromLiveStreamItem;
34
import static org.schabi.newpipe.extractor.stream.AudioStream.UNKNOWN_BITRATE;
45
import static org.schabi.newpipe.extractor.stream.Stream.ID_UNKNOWN;
56

67
import com.grack.nanojson.JsonArray;
78
import com.grack.nanojson.JsonObject;
89

10+
import org.schabi.newpipe.extractor.Image;
911
import org.schabi.newpipe.extractor.MediaFormat;
1012
import org.schabi.newpipe.extractor.StreamingService;
1113
import org.schabi.newpipe.extractor.downloader.Downloader;
@@ -77,8 +79,8 @@ public String getName() throws ParsingException {
7779

7880
@Nonnull
7981
@Override
80-
public String getThumbnailUrl() throws ParsingException {
81-
return room.getString("thumb");
82+
public List<Image> getThumbnails() throws ParsingException {
83+
return getThumbnailsFromLiveStreamItem(room);
8284
}
8385

8486
@Nonnull

extractor/src/main/java/org/schabi/newpipe/extractor/services/media_ccc/extractors/MediaCCCSearchExtractor.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,17 @@
99
import com.grack.nanojson.JsonParser;
1010
import com.grack.nanojson.JsonParserException;
1111

12+
import org.schabi.newpipe.extractor.Image;
1213
import org.schabi.newpipe.extractor.InfoItem;
1314
import org.schabi.newpipe.extractor.MetaInfo;
15+
import org.schabi.newpipe.extractor.MultiInfoItemsCollector;
1416
import org.schabi.newpipe.extractor.Page;
1517
import org.schabi.newpipe.extractor.StreamingService;
1618
import org.schabi.newpipe.extractor.channel.ChannelInfoItem;
1719
import org.schabi.newpipe.extractor.channel.ChannelInfoItemExtractor;
1820
import org.schabi.newpipe.extractor.downloader.Downloader;
1921
import org.schabi.newpipe.extractor.exceptions.ExtractionException;
2022
import org.schabi.newpipe.extractor.linkhandler.SearchQueryHandler;
21-
import org.schabi.newpipe.extractor.MultiInfoItemsCollector;
2223
import org.schabi.newpipe.extractor.search.SearchExtractor;
2324
import org.schabi.newpipe.extractor.services.media_ccc.extractors.infoItems.MediaCCCStreamInfoItemExtractor;
2425
import org.schabi.newpipe.extractor.services.media_ccc.linkHandler.MediaCCCConferencesListLinkHandlerFactory;
@@ -157,9 +158,10 @@ public String getUrl() {
157158
return item.getUrl();
158159
}
159160

161+
@Nonnull
160162
@Override
161-
public String getThumbnailUrl() {
162-
return item.getThumbnailUrl();
163+
public List<Image> getThumbnails() {
164+
return item.getThumbnails();
163165
}
164166
});
165167
}

extractor/src/main/java/org/schabi/newpipe/extractor/services/media_ccc/extractors/MediaCCCStreamExtractor.java

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
package org.schabi.newpipe.extractor.services.media_ccc.extractors;
22

3+
import static org.schabi.newpipe.extractor.services.media_ccc.extractors.MediaCCCParsingHelper.getImageListFromLogoImageUrl;
4+
import static org.schabi.newpipe.extractor.services.media_ccc.extractors.MediaCCCParsingHelper.getThumbnailsFromStreamItem;
5+
import static org.schabi.newpipe.extractor.services.media_ccc.extractors.MediaCCCParsingHelper.parseDateFrom;
36
import static org.schabi.newpipe.extractor.stream.AudioStream.UNKNOWN_BITRATE;
47
import static org.schabi.newpipe.extractor.stream.Stream.ID_UNKNOWN;
58

@@ -8,6 +11,7 @@
811
import com.grack.nanojson.JsonParser;
912
import com.grack.nanojson.JsonParserException;
1013

14+
import org.schabi.newpipe.extractor.Image;
1115
import org.schabi.newpipe.extractor.MediaFormat;
1216
import org.schabi.newpipe.extractor.StreamingService;
1317
import org.schabi.newpipe.extractor.downloader.Downloader;
@@ -51,13 +55,13 @@ public String getTextualUploadDate() {
5155
@Nonnull
5256
@Override
5357
public DateWrapper getUploadDate() throws ParsingException {
54-
return new DateWrapper(MediaCCCParsingHelper.parseDateFrom(getTextualUploadDate()));
58+
return new DateWrapper(parseDateFrom(getTextualUploadDate()));
5559
}
5660

5761
@Nonnull
5862
@Override
59-
public String getThumbnailUrl() {
60-
return data.getString("thumb_url");
63+
public List<Image> getThumbnails() {
64+
return getThumbnailsFromStreamItem(data);
6165
}
6266

6367
@Nonnull
@@ -91,8 +95,8 @@ public String getUploaderName() {
9195

9296
@Nonnull
9397
@Override
94-
public String getUploaderAvatarUrl() {
95-
return conferenceData.getString("logo_url");
98+
public List<Image> getUploaderAvatars() {
99+
return getImageListFromLogoImageUrl(conferenceData.getString("logo_url"));
96100
}
97101

98102
@Override

0 commit comments

Comments
 (0)