Merge pull request #337 from wb9688/next-stream

Remove getNextStream() from StreamExtractor

Author: TobiGr

extractor/src/main/java/org/schabi/newpipe/extractor/services/media_ccc/extractors/MediaCCCStreamExtractor.java

@@ -15,7 +15,6 @@
 import org.schabi.newpipe.extractor.stream.AudioStream;
 import org.schabi.newpipe.extractor.stream.Description;
 import org.schabi.newpipe.extractor.stream.StreamExtractor;
-import org.schabi.newpipe.extractor.stream.StreamInfoItem;
 import org.schabi.newpipe.extractor.stream.StreamInfoItemsCollector;
 import org.schabi.newpipe.extractor.stream.StreamType;
 import org.schabi.newpipe.extractor.stream.SubtitlesStream;
@@ -215,11 +214,6 @@ public StreamType getStreamType() {
         return StreamType.VIDEO_STREAM;
     }
 
-    @Override
-    public StreamInfoItem getNextStream() {
-        return null;
-    }
-
     @Override
     public StreamInfoItemsCollector getRelatedStreams() {
         return new StreamInfoItemsCollector(getServiceId());

extractor/src/main/java/org/schabi/newpipe/extractor/services/peertube/extractors/PeertubeStreamExtractor.java

@@ -21,7 +21,6 @@
 import org.schabi.newpipe.extractor.stream.Description;
 import org.schabi.newpipe.extractor.stream.Stream;
 import org.schabi.newpipe.extractor.stream.StreamExtractor;
-import org.schabi.newpipe.extractor.stream.StreamInfoItem;
 import org.schabi.newpipe.extractor.stream.StreamInfoItemsCollector;
 import org.schabi.newpipe.extractor.stream.StreamType;
 import org.schabi.newpipe.extractor.stream.SubtitlesStream;
@@ -242,11 +241,6 @@ public StreamType getStreamType() {
         return StreamType.VIDEO_STREAM;
     }
 
-    @Override
-    public StreamInfoItem getNextStream() {
-        return null;
-    }
-
     @Override
     public StreamInfoItemsCollector getRelatedStreams() throws IOException, ExtractionException {
         final StreamInfoItemsCollector collector = new StreamInfoItemsCollector(getServiceId());

extractor/src/main/java/org/schabi/newpipe/extractor/services/soundcloud/extractors/SoundcloudStreamExtractor.java

@@ -19,7 +19,6 @@
 import org.schabi.newpipe.extractor.stream.AudioStream;
 import org.schabi.newpipe.extractor.stream.Description;
 import org.schabi.newpipe.extractor.stream.StreamExtractor;
-import org.schabi.newpipe.extractor.stream.StreamInfoItem;
 import org.schabi.newpipe.extractor.stream.StreamInfoItemsCollector;
 import org.schabi.newpipe.extractor.stream.StreamType;
 import org.schabi.newpipe.extractor.stream.SubtitlesStream;
@@ -261,11 +260,6 @@ public StreamType getStreamType() {
         return StreamType.AUDIO_STREAM;
     }
 
-    @Override
-    public StreamInfoItem getNextStream() throws IOException, ExtractionException {
-        return null;
-    }
-
     @Override
     public StreamInfoItemsCollector getRelatedStreams() throws IOException, ExtractionException {
         StreamInfoItemsCollector collector = new StreamInfoItemsCollector(getServiceId());

extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java

@@ -21,14 +21,14 @@
 import org.schabi.newpipe.extractor.localization.TimeAgoParser;
 import org.schabi.newpipe.extractor.localization.TimeAgoPatternsManager;
 import org.schabi.newpipe.extractor.services.youtube.ItagItem;
-import org.schabi.newpipe.extractor.services.youtube.linkHandler.YoutubeChannelLinkHandlerFactory;
 import org.schabi.newpipe.extractor.services.youtube.YoutubeParsingHelper;
+import org.schabi.newpipe.extractor.services.youtube.linkHandler.YoutubeChannelLinkHandlerFactory;
 import org.schabi.newpipe.extractor.stream.AudioStream;
 import org.schabi.newpipe.extractor.stream.Description;
 import org.schabi.newpipe.extractor.stream.Frameset;
 import org.schabi.newpipe.extractor.stream.Stream;
 import org.schabi.newpipe.extractor.stream.StreamExtractor;
-import org.schabi.newpipe.extractor.stream.StreamInfoItem;
+import org.schabi.newpipe.extractor.stream.StreamInfoItemExtractor;
 import org.schabi.newpipe.extractor.stream.StreamInfoItemsCollector;
 import org.schabi.newpipe.extractor.stream.StreamType;
 import org.schabi.newpipe.extractor.stream.SubtitlesStream;
@@ -52,7 +52,10 @@
 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
 
-import static org.schabi.newpipe.extractor.services.youtube.YoutubeParsingHelper.*;
+import static org.schabi.newpipe.extractor.services.youtube.YoutubeParsingHelper.fixThumbnailUrl;
+import static org.schabi.newpipe.extractor.services.youtube.YoutubeParsingHelper.getJsonResponse;
+import static org.schabi.newpipe.extractor.services.youtube.YoutubeParsingHelper.getTextFromObject;
+import static org.schabi.newpipe.extractor.services.youtube.YoutubeParsingHelper.getUrlFromNavigationEndpoint;
 import static org.schabi.newpipe.extractor.utils.JsonUtils.EMPTY_STRING;
 import static org.schabi.newpipe.extractor.utils.Utils.isNullOrEmpty;
 
@@ -508,12 +511,7 @@ public StreamType getStreamType() throws ParsingException {
         return StreamType.VIDEO_STREAM;
     }
 
-    @Override
-    public StreamInfoItem getNextStream() throws ExtractionException {
-        assertPageFetched();
-
-        if (getAgeLimit() != NO_AGE_LIMIT) return null;
-
+    private StreamInfoItemExtractor getNextStream() throws ExtractionException {
         try {
             final JsonObject firstWatchNextItem = initialData.getObject("contents")
                     .getObject("twoColumnWatchNextResults").getObject("secondaryResults")
@@ -527,11 +525,7 @@ public StreamInfoItem getNextStream() throws ExtractionException {
             final JsonObject videoInfo = firstWatchNextItem.getObject("compactAutoplayRenderer")
                     .getArray("contents").getObject(0).getObject("compactVideoRenderer");
 
-            final TimeAgoParser timeAgoParser = getTimeAgoParser();
-            StreamInfoItemsCollector collector = new StreamInfoItemsCollector(getServiceId());
-
-            collector.commit(new YoutubeStreamInfoItemExtractor(videoInfo, timeAgoParser));
-            return collector.getItems().get(0);
+            return new YoutubeStreamInfoItemExtractor(videoInfo, getTimeAgoParser());
         } catch (Exception e) {
             throw new ParsingException("Could not get next video", e);
         }
@@ -544,13 +538,19 @@ public StreamInfoItemsCollector getRelatedStreams() throws ExtractionException {
         if (getAgeLimit() != NO_AGE_LIMIT) return null;
 
         try {
-            StreamInfoItemsCollector collector = new StreamInfoItemsCollector(getServiceId());
-            JsonArray results = initialData.getObject("contents").getObject("twoColumnWatchNextResults")
+            final StreamInfoItemsCollector collector = new StreamInfoItemsCollector(getServiceId());
+
+            final StreamInfoItemExtractor nextStream = getNextStream();
+            if (nextStream != null) {
+                collector.commit(nextStream);
+            }
+
+            final JsonArray results = initialData.getObject("contents").getObject("twoColumnWatchNextResults")
                     .getObject("secondaryResults").getObject("secondaryResults").getArray("results");
 
             final TimeAgoParser timeAgoParser = getTimeAgoParser();
 
-            for (Object ul : results) {
+            for (final Object ul : results) {
                 if (((JsonObject) ul).has("compactVideoRenderer")) {
                     collector.commit(new YoutubeStreamInfoItemExtractor(((JsonObject) ul).getObject("compactVideoRenderer"), timeAgoParser));
                 }

extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamExtractor.java

@@ -30,13 +30,14 @@
 import org.schabi.newpipe.extractor.localization.DateWrapper;
 import org.schabi.newpipe.extractor.utils.Parser;
 
-import javax.annotation.Nonnull;
-import javax.annotation.Nullable;
 import java.io.IOException;
 import java.util.Collections;
 import java.util.List;
 import java.util.Locale;
 
+import javax.annotation.Nonnull;
+import javax.annotation.Nullable;
+
 /**
  * Scrapes information from a video/audio streaming service (eg, YouTube).
  */
@@ -309,23 +310,12 @@ public StreamExtractor(StreamingService service, LinkHandler linkHandler) {
      */
     public abstract StreamType getStreamType() throws ParsingException;
 
-    /**
-     * Should return the url of the next stream. NewPipe will automatically play
-     * the next stream if the user wants that.
-     * If the next stream is is not available simply return null
-     *
-     * @return the InfoItem of the next stream
-     * @throws IOException
-     * @throws ExtractionException
-     */
-    public abstract StreamInfoItem getNextStream() throws IOException, ExtractionException;
-
     /**
      * Should return a list of streams related to the current handled. Many services show suggested
      * streams. If you don't like suggested streams you should implement them anyway since they can
-     * be disabled by the user later in the frontend.
-     * This list MUST NOT contain the next available video as this should be return through getNextStream()
-     * If it is not available simply return null
+     * be disabled by the user later in the frontend. The first related stream might be what was
+     * previously known as a next stream.
+     * If related streams aren't available simply return {@code null}.
      *
      * @return a list of InfoItems showing the related videos/streams
      * @throws IOException
@@ -337,11 +327,10 @@ public StreamExtractor(StreamingService service, LinkHandler linkHandler) {
      * Should return a list of Frameset object that contains preview of stream frames
      *
      * @return list of preview frames or empty list if frames preview is not supported or not found for specified stream
-     * @throws IOException
      * @throws ExtractionException
      */
     @Nonnull
-    public List<Frameset> getFrames() throws IOException, ExtractionException {
+    public List<Frameset> getFrames() throws ExtractionException {
         return Collections.emptyList();
     }
 

extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamInfo.java

@@ -282,11 +282,6 @@ private static StreamInfo extractOptionalData(StreamInfo streamInfo, StreamExtra
         } catch (Exception e) {
             streamInfo.addError(e);
         }
-        try {
-            streamInfo.setNextVideo(extractor.getNextStream());
-        } catch (Exception e) {
-            streamInfo.addError(e);
-        }
         try {
             streamInfo.setSubtitles(extractor.getSubtitlesDefault());
         } catch (Exception e) {
@@ -366,7 +361,6 @@ private static StreamInfo extractOptionalData(StreamInfo streamInfo, StreamExtra
 
 
     private String hlsUrl = "";
-    private StreamInfoItem nextVideo;
     private List<InfoItem> relatedStreams = new ArrayList<>();
 
     private long startPosition = 0;
@@ -597,14 +591,6 @@ public void setHlsUrl(String hlsUrl) {
         this.hlsUrl = hlsUrl;
     }
 
-    public StreamInfoItem getNextVideo() {
-        return nextVideo;
-    }
-
-    public void setNextVideo(StreamInfoItem nextVideo) {
-        this.nextVideo = nextVideo;
-    }
-
     public List<InfoItem> getRelatedStreams() {
         return relatedStreams;
     }

extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/stream/YoutubeStreamExtractorUnlistedTest.java

@@ -129,11 +129,6 @@ public void testStreamType() throws ParsingException {
         assertSame(StreamType.VIDEO_STREAM, extractor.getStreamType());
     }
 
-    @Test
-    public void testGetNextVideo() throws ExtractionException {
-        assertNull(extractor.getNextStream());
-    }
-
     @Test
     public void testGetRelatedVideos() throws ExtractionException {
         StreamInfoItemsCollector relatedVideos = extractor.getRelatedStreams();