Improve Channel and Playlist tests

Author: mauriciocolli

src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeChannelExtractor.java

@@ -201,7 +201,7 @@ private String getNextPageUrlFrom(Document d) throws ParsingException {
                 return "";
             }
         } catch (Exception e) {
-            throw new ParsingException("could not get next streams' url", e);
+            throw new ParsingException("Could not get next page url", e);
         }
     }
 

src/test/java/org/schabi/newpipe/extractor/ExtractorAsserts.java

@@ -1,19 +1,22 @@
 package org.schabi.newpipe.extractor;
 
 import javax.annotation.Nonnull;
+import javax.annotation.Nullable;
 import java.net.MalformedURLException;
 import java.net.URL;
 import java.util.List;
 
-import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.*;
 
 public class ExtractorAsserts {
     public static void assertEmptyErrors(String message, List<Throwable> errors) {
-        if(!errors.isEmpty()) {
-            for (Throwable throwable : errors) {
-                message += "\n  * " + throwable.getMessage();
+        if (!errors.isEmpty()) {
+            StringBuilder messageBuilder = new StringBuilder(message);
+            for (Throwable e : errors) {
+                messageBuilder.append("\n  * ").append(e.getMessage());
             }
-            throw new AssertionError(message, errors.get(0));
+            messageBuilder.append(" ");
+            throw new AssertionError(messageBuilder.toString(), errors.get(0));
         }
     }
 
@@ -22,7 +25,7 @@ private static URL urlFromString(String url) {
         try {
             return new URL(url);
         } catch (MalformedURLException e) {
-            throw new AssertionError("Invalid url: " + url, e);
+            throw new AssertionError("Invalid url: " + "\"" + url + "\"", e);
         }
     }
 
@@ -34,4 +37,23 @@ public static void assertIsSecureUrl(String urlToCheck) {
         URL url = urlFromString(urlToCheck);
         assertEquals("Protocol of URL is not secure", "https", url.getProtocol());
     }
+
+    public static void assertNotEmpty(String stringToCheck) {
+        assertNotEmpty(null, stringToCheck);
+    }
+
+    public static void assertNotEmpty(@Nullable String message, String stringToCheck) {
+        assertNotNull(message, stringToCheck);
+        assertFalse(message, stringToCheck.isEmpty());
+    }
+
+    public static void assertEmpty(String stringToCheck) {
+        assertEmpty(null, stringToCheck);
+    }
+
+    public static void assertEmpty(@Nullable String message, String stringToCheck) {
+        if (stringToCheck != null) {
+            assertTrue(message, stringToCheck.isEmpty());
+        }
+    }
 }

src/test/java/org/schabi/newpipe/extractor/services/BaseChannelExtractorTest.java

@@ -0,0 +1,10 @@
+package org.schabi.newpipe.extractor.services;
+
+@SuppressWarnings("unused")
+public interface BaseChannelExtractorTest extends BaseListExtractorTest {
+    void testDescription() throws Exception;
+    void testAvatarUrl() throws Exception;
+    void testBannerUrl() throws Exception;
+    void testFeedUrl() throws Exception;
+    void testSubscriberCount() throws Exception;
+}

src/test/java/org/schabi/newpipe/extractor/services/BaseExtractorTest.java

@@ -0,0 +1,10 @@
+package org.schabi.newpipe.extractor.services;
+
+@SuppressWarnings("unused")
+public interface BaseExtractorTest {
+    void testServiceId() throws Exception;
+    void testName() throws Exception;
+    void testId() throws Exception;
+    void testCleanUrl() throws Exception;
+    void testOriginalUrl() throws Exception;
+}

src/test/java/org/schabi/newpipe/extractor/services/BaseListExtractorTest.java

@@ -0,0 +1,65 @@
+package org.schabi.newpipe.extractor.services;
+
+import org.schabi.newpipe.extractor.InfoItem;
+import org.schabi.newpipe.extractor.InfoItemsCollector;
+import org.schabi.newpipe.extractor.ListExtractor;
+import org.schabi.newpipe.extractor.stream.StreamInfoItem;
+
+import java.util.List;
+
+import static org.junit.Assert.*;
+import static org.schabi.newpipe.extractor.ExtractorAsserts.*;
+
+public interface BaseListExtractorTest extends BaseExtractorTest {
+    @SuppressWarnings("unused")
+    void testRelatedItems() throws Exception;
+    @SuppressWarnings("unused")
+    void testMoreRelatedItems() throws Exception;
+
+
+    static void defaultTestListOfItems(int expectedServiceId, List<? extends InfoItem> itemsList, List<Throwable> errors) {
+        assertTrue("List of items is empty", !itemsList.isEmpty());
+        assertFalse("List of items contains a null element", itemsList.contains(null));
+        assertEmptyErrors("Errors during stream list extraction", errors);
+
+        for (InfoItem item : itemsList) {
+            assertIsSecureUrl(item.getUrl());
+            if (item.getThumbnailUrl() != null && !item.getThumbnailUrl().isEmpty()) {
+                assertIsSecureUrl(item.getThumbnailUrl());
+            }
+            assertNotNull("InfoItem type not set: " + item, item.getInfoType());
+            assertEquals("Service id doesn't match: " + item, expectedServiceId, item.getServiceId());
+
+            if (item instanceof StreamInfoItem) {
+                StreamInfoItem streamInfoItem = (StreamInfoItem) item;
+                assertNotEmpty("Uploader name not set: " + item, streamInfoItem.getUploaderName());
+                assertNotEmpty("Uploader url not set: " + item, streamInfoItem.getUploaderUrl());
+            }
+        }
+    }
+
+    static void defaultTestRelatedItems(ListExtractor extractor, int expectedServiceId) throws Exception {
+        final InfoItemsCollector<? extends InfoItem, ?> itemsCollector = extractor.getInfoItems();
+        final List<? extends InfoItem> itemsList = itemsCollector.getItemList();
+        List<Throwable> errors = itemsCollector.getErrors();
+
+        defaultTestListOfItems(expectedServiceId, itemsList, errors);
+    }
+
+    static ListExtractor.InfoItemPage<? extends InfoItem> defaultTestMoreItems(ListExtractor extractor, int expectedServiceId) throws Exception {
+        assertTrue("Doesn't have more items", extractor.hasNextPage());
+        ListExtractor.InfoItemPage<? extends InfoItem> nextPage = extractor.getPage(extractor.getNextPageUrl());
+        assertTrue("Next page is empty", !nextPage.getItemsList().isEmpty());
+        assertEmptyErrors("Next page have errors", nextPage.getErrors());
+
+        defaultTestListOfItems(expectedServiceId, nextPage.getItemsList(), nextPage.getErrors());
+        return nextPage;
+    }
+
+    static void defaultTestGetPageInNewExtractor(ListExtractor extractor, ListExtractor newExtractor, int expectedServiceId) throws Exception {
+        final String nextPageUrl = extractor.getNextPageUrl();
+
+        final ListExtractor.InfoItemPage<? extends InfoItem> page = newExtractor.getPage(nextPageUrl);
+        BaseListExtractorTest.defaultTestListOfItems(expectedServiceId, page.getItemsList(), page.getErrors());
+    }
+}

src/test/java/org/schabi/newpipe/extractor/services/BasePlaylistExtractorTest.java

@@ -0,0 +1,11 @@
+package org.schabi.newpipe.extractor.services;
+
+@SuppressWarnings("unused")
+public interface BasePlaylistExtractorTest extends BaseListExtractorTest {
+    void testThumbnailUrl() throws Exception;
+    void testBannerUrl() throws Exception;
+    void testUploaderUrl() throws Exception;
+    void testUploaderName() throws Exception;
+    void testUploaderAvatarUrl() throws Exception;
+    void testStreamCount() throws Exception;
+}