Make ALL tests mockable

Also:
* Removed unused mock only
* Cache downloader type

Author: litetex

extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamInfoItemLockupExtractor.java

@@ -17,6 +17,7 @@
 import org.schabi.newpipe.extractor.utils.JsonUtils;
 import org.schabi.newpipe.extractor.utils.Utils;
 
+import java.util.ArrayList;
 import java.util.List;
 import java.util.Optional;
 import java.util.stream.Collectors;

extractor/src/test/java/org/schabi/newpipe/downloader/DownloaderFactory.java

@@ -2,22 +2,56 @@
 
 import org.schabi.newpipe.extractor.downloader.Downloader;
 
-import java.io.IOException;
+import java.util.Locale;
 
 public class DownloaderFactory {
 
-    public static final String RESOURCE_PATH = "src/test/resources/org/schabi/newpipe/extractor/";
-
     private static final DownloaderType DEFAULT_DOWNLOADER = DownloaderType.REAL;
 
-    public static DownloaderType getDownloaderType() {
+    private static DownloaderType cachedDownloaderType;
+
+    private static DownloaderType getDownloaderType() {
+        if (cachedDownloaderType == null) {
+            cachedDownloaderType = determineDownloaderType();
+        }
+
+        return cachedDownloaderType;
+    }
+
+    private static DownloaderType determineDownloaderType() {
+        String propValue = System.getProperty("downloader");
+        if (propValue == null) {
+            return DEFAULT_DOWNLOADER;
+        }
+        propValue = propValue.toUpperCase();
+        // Use shortcut because RECORDING is quite wrong
+        if (propValue.equals("REC")) {
+            return DownloaderType.RECORDING;
+        }
         try {
-            return DownloaderType.valueOf(System.getProperty("downloader"));
+            return DownloaderType.valueOf(propValue);
         } catch (final Exception e) {
             return DEFAULT_DOWNLOADER;
         }
     }
 
+    public static Downloader getDownloader(final Class<?> clazz) {
+        return getDownloader(clazz, null);
+    }
+
+    public static Downloader getDownloader(final Class<?> clazz, final String specificUseCase) {
+        String baseName = clazz.getName();
+        if (specificUseCase != null) {
+            baseName += "." + specificUseCase;
+        }
+        return getDownloader("src/test/resources/mocks/v1/"
+            + baseName
+            .toLowerCase(Locale.ENGLISH)
+            .replace('$', '.')
+            .replace("test", "")
+            .replace('.', '/'));
+    }
+
     /**
      * <p>
      * Returns a implementation of a {@link Downloader}.
@@ -34,9 +68,8 @@ public static DownloaderType getDownloaderType() {
      * </p>
      *
      * @param path The path to the folder where mocks are saved/retrieved.
-     *             Preferably starting with {@link DownloaderFactory#RESOURCE_PATH}
      */
-    public static Downloader getDownloader(final String path) {
+    protected static Downloader getDownloader(final String path) {
         final DownloaderType type = getDownloaderType();
         switch (type) {
             case REAL:

extractor/src/test/java/org/schabi/newpipe/downloader/MockOnly.java

@@ -23,7 +23,7 @@ public class RateLimitedClientWrapper {
         Map.entry(host -> host.endsWith("youtube.com"),
             RateLimiter.create(1.6, Duration.ofSeconds(1))),
         Map.entry(host -> host.endsWith("bandcamp.com"),
-            RateLimiter.create(2.5, Duration.ofSeconds(1)))
+            RateLimiter.create(1.6, Duration.ofSeconds(1)))
     );
 
     private final OkHttpClient client;

extractor/src/test/java/org/schabi/newpipe/downloader/MockOnlyCondition.java

@@ -0,0 +1,30 @@
+package org.schabi.newpipe.extractor;
+
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.TestInstance;
+import org.schabi.newpipe.downloader.DownloaderFactory;
+
+@TestInstance(TestInstance.Lifecycle.PER_CLASS)
+public interface InitNewPipeTest {
+
+    @BeforeAll
+    default void setUp() throws Exception {
+        initNewPipe(this.getClass());
+    }
+
+    static void initNewPipe(final Class<?> clazz) {
+        NewPipe.init(DownloaderFactory.getDownloader(clazz));
+    }
+
+    static void initNewPipe(final Class<?> clazz, final String specificUseCase) {
+        NewPipe.init(DownloaderFactory.getDownloader(clazz, specificUseCase));
+    }
+
+    /**
+     * Ensures that NewPipe is not initialized.
+     * This can be used to ensure that a class works standalone and does e.g. no network requests.
+     */
+    static void initEmpty() {
+        NewPipe.init(null, null, null);
+    }
+}

extractor/src/test/java/org/schabi/newpipe/downloader/ratelimiting/RateLimitedClientWrapper.java

@@ -1,7 +1,9 @@
 package org.schabi.newpipe.extractor.services;
 
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.TestInstance;
 
+@TestInstance(TestInstance.Lifecycle.PER_CLASS)
 public interface BaseExtractorTest {
     @Test
     void testServiceId() throws Exception;

extractor/src/test/java/org/schabi/newpipe/extractor/InitNewPipeTest.java

@@ -1,15 +1,16 @@
 package org.schabi.newpipe.extractor.services;
 
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.schabi.newpipe.extractor.ExtractorAsserts.assertIsSecureUrl;
+
 import org.junit.jupiter.api.Test;
 import org.schabi.newpipe.extractor.Extractor;
 import org.schabi.newpipe.extractor.ExtractorAsserts;
 import org.schabi.newpipe.extractor.StreamingService;
 
-import static org.junit.jupiter.api.Assertions.*;
-import static org.schabi.newpipe.extractor.ExtractorAsserts.assertIsSecureUrl;
-
-public abstract class DefaultExtractorTest<T extends Extractor> implements BaseExtractorTest {
-    public abstract T extractor() throws Exception;
+public abstract class DefaultExtractorTest<T extends Extractor>
+    extends DefaultSimpleExtractorTest<T>
+    implements BaseExtractorTest {
 
     public abstract StreamingService expectedService() throws Exception;
     public abstract String expectedName() throws Exception;

extractor/src/test/java/org/schabi/newpipe/extractor/services/BaseExtractorTest.java

@@ -0,0 +1,11 @@
+package org.schabi.newpipe.extractor.services;
+
+import org.schabi.newpipe.extractor.Extractor;
+
+public abstract class DefaultSimpleExtractorTest<T extends Extractor> extends DefaultSimpleUntypedExtractorTest<T> {
+
+    @Override
+    protected void fetchExtractor(final T extractor) throws Exception {
+        extractor.fetchPage();
+    }
+}

extractor/src/test/java/org/schabi/newpipe/extractor/services/DefaultExtractorTest.java

@@ -0,0 +1,32 @@
+package org.schabi.newpipe.extractor.services;
+
+import org.schabi.newpipe.extractor.InitNewPipeTest;
+
+public abstract class DefaultSimpleUntypedExtractorTest<T> implements InitNewPipeTest {
+
+    private T extractor;
+
+    protected void initExtractor() throws Exception {
+        extractor = createExtractor();
+        fetchExtractor(extractor);
+    }
+
+    protected abstract T createExtractor() throws Exception;
+
+    protected void fetchExtractor(final T extractor) throws Exception {
+    }
+
+    protected T extractor() {
+        if (extractor == null) {
+            try {
+                initExtractor();
+            } catch (final Exception ex) {
+                if(ex instanceof RuntimeException) {
+                    throw (RuntimeException)ex;
+                }
+                throw new RuntimeException("Failed to init extractor", ex);
+            }
+        }
+        return extractor;
+    }
+}