[SoundCloud] Fix concurrency issue when getting the client id

mauriciocolli · mauriciocolli · commit d2f1c0f40d67 · 2020-06-24T01:50:08.000-03:00
diff --git a/extractor/src/main/java/org/schabi/newpipe/extractor/services/soundcloud/SoundcloudParsingHelper.java b/extractor/src/main/java/org/schabi/newpipe/extractor/services/soundcloud/SoundcloudParsingHelper.java
@@ -43,13 +43,15 @@ public class SoundcloudParsingHelper {
     private SoundcloudParsingHelper() {
     }
 
-    public static String clientId() throws ExtractionException, IOException {
+    public synchronized static String clientId() throws ExtractionException, IOException {
         if (!isNullOrEmpty(clientId)) return clientId;
 
         Downloader dl = NewPipe.getDownloader();
         clientId = HARDCODED_CLIENT_ID;
         if (checkIfHardcodedClientIdIsValid()) {
             return clientId;
+        } else {
+            clientId = null;
         }
 
         final Response download = dl.get("https://soundcloud.com");

Original file line number	Diff line number	Diff line change
`@@ -43,13 +43,15 @@ public class SoundcloudParsingHelper {`
`43`	`43`	`private SoundcloudParsingHelper() {`
`44`	`44`	`}`
`45`	`45`
`46`		`- public static String clientId() throws ExtractionException, IOException {`
	`46`	`+ public synchronized static String clientId() throws ExtractionException, IOException {`
`47`	`47`	`if (!isNullOrEmpty(clientId)) return clientId;`
`48`	`48`
`49`	`49`	`Downloader dl = NewPipe.getDownloader();`
`50`	`50`	`clientId = HARDCODED_CLIENT_ID;`
`51`	`51`	`if (checkIfHardcodedClientIdIsValid()) {`
`52`	`52`	`return clientId;`
	`53`	`+ } else {`
	`54`	`+ clientId = null;`
`53`	`55`	`}`
`54`	`56`
`55`	`57`	`final Response download = dl.get("https://soundcloud.com");`