Skip to content

Commit d0efe8b

Browse files
committed
fix ogg
1 parent 644da4f commit d0efe8b

3 files changed

Lines changed: 47 additions & 3 deletions

File tree

extractor/src/main/java/org/schabi/newpipe/extractor/services/media_ccc/extractors/MediaCCCStreamExtractor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,8 @@ public List<AudioStream> getAudioStreams() throws IOException, ExtractionExcepti
121121
mediaFormat = MediaFormat.OPUS;
122122
} else if(mimeType.endsWith("mpeg")) {
123123
mediaFormat = MediaFormat.MP3;
124+
} else if(mimeType.endsWith("ogg")){
125+
mediaFormat = MediaFormat.OGG;
124126
} else {
125127
throw new ExtractionException("Unknown media format: " + mimeType);
126128
}
@@ -146,8 +148,6 @@ public List<VideoStream> getVideoStreams() throws IOException, ExtractionExcepti
146148
mediaFormat = MediaFormat.WEBM;
147149
} else if(mimeType.endsWith("mp4")) {
148150
mediaFormat = MediaFormat.MPEG_4;
149-
} else if(mimeType.endsWith("ogg")){
150-
mediaFormat = MediaFormat.OGG;
151151
} else {
152152
throw new ExtractionException("Unknown media format: " + mimeType);
153153
}
Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
package org.schabi.newpipe.extractor.services.media_ccc;
2+
3+
import org.junit.BeforeClass;
4+
import org.junit.Test;
5+
import org.schabi.newpipe.Downloader;
6+
import org.schabi.newpipe.extractor.NewPipe;
7+
import org.schabi.newpipe.extractor.services.media_ccc.extractors.MediaCCCStreamExtractor;
8+
import org.schabi.newpipe.extractor.stream.AudioStream;
9+
import org.schabi.newpipe.extractor.stream.StreamExtractor;
10+
import org.schabi.newpipe.extractor.utils.Localization;
11+
12+
13+
import static junit.framework.TestCase.assertEquals;
14+
import static org.schabi.newpipe.extractor.ServiceList.MediaCCC;
15+
16+
/**
17+
* Test {@link MediaCCCStreamExtractor}
18+
*/
19+
public class MediaCCCOggTest {
20+
// test against https://api.media.ccc.de/public/events/1317
21+
private static StreamExtractor extractor;
22+
23+
@BeforeClass
24+
public static void setUpClass() throws Exception {
25+
NewPipe.init(Downloader.getInstance(), new Localization("GB", "en"));
26+
27+
extractor = MediaCCC.getStreamExtractor("https://api.media.ccc.de/public/events/1317");
28+
extractor.fetchPage();
29+
}
30+
31+
@Test
32+
public void getAudioStreamsCount() throws Exception {
33+
assertEquals(1, extractor.getAudioStreams().size());
34+
}
35+
36+
@Test
37+
public void getAudioStreamsContainOgg() throws Exception {
38+
for(AudioStream stream : extractor.getAudioStreams()) {
39+
System.out.println(stream.getFormat());
40+
}
41+
}
42+
}

extractor/src/test/java/org/schabi/newpipe/extractor/services/media_ccc/MediaCCCSearchExtractorAllTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public class MediaCCCSearchExtractorAllTest {
3030
public static void setUpClass() throws Exception {
3131
NewPipe.init(Downloader.getInstance(), new Localization("GB", "en"));
3232
extractor = MediaCCC.getSearchExtractor( new MediaCCCSearchQueryHandlerFactory()
33-
.fromQuery("c", Arrays.asList(new String[] {"all"}), "")
33+
.fromQuery("c3", Arrays.asList(new String[] {"all"}), "")
3434
,new Localization("GB", "en"));
3535
extractor.fetchPage();
3636
itemsPage = extractor.getInitialPage();
@@ -40,6 +40,7 @@ public static void setUpClass() throws Exception {
4040
public void testIfChannelInfoItemsAvailable() {
4141
boolean isAvialable = false;
4242
for(InfoItem item : itemsPage.getItems()) {
43+
System.out.println(item);
4344
if(item instanceof ChannelInfoItem) {
4445
isAvialable = true;
4546
}
@@ -51,6 +52,7 @@ public void testIfChannelInfoItemsAvailable() {
5152
public void testIfStreamInfoitemsAvailable() {
5253
boolean isAvialable = false;
5354
for(InfoItem item : itemsPage.getItems()) {
55+
System.out.println(item);
5456
if(item instanceof StreamInfoItem) {
5557
isAvialable = true;
5658
}

0 commit comments

Comments
 (0)