Skip to content

Commit b481a22

Browse files
authored
Merge pull request #598 from XiangRongLin/fix_tests
Fix a test and ignore rest
2 parents 1925dcf + 3d70b6d commit b481a22

3 files changed

Lines changed: 14 additions & 1 deletion

File tree

extractor/src/test/java/org/schabi/newpipe/extractor/services/peertube/PeertubePlaylistExtractorTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package org.schabi.newpipe.extractor.services.peertube;
22

33
import org.junit.BeforeClass;
4+
import org.junit.Ignore;
45
import org.junit.Test;
56
import org.schabi.newpipe.downloader.DownloaderTestImpl;
67
import org.schabi.newpipe.extractor.ExtractorAsserts;
@@ -30,6 +31,7 @@ public void testGetName() throws ParsingException {
3031
}
3132

3233
@Test
34+
@Ignore("URL changes with every request")
3335
public void testGetThumbnailUrl() throws ParsingException {
3436
assertEquals("https://framatube.org/static/thumbnails/playlist-96b0ee2b-a5a7-4794-8769-58d8ccb79ab7.jpg", extractor.getThumbnailUrl());
3537
}

extractor/src/test/java/org/schabi/newpipe/extractor/services/peertube/search/PeertubeSearchExtractorTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package org.schabi.newpipe.extractor.services.peertube.search;
22

33
import org.junit.BeforeClass;
4+
import org.junit.Ignore;
45
import org.junit.Test;
56
import org.schabi.newpipe.downloader.DownloaderTestImpl;
67
import org.schabi.newpipe.extractor.InfoItem;
@@ -69,6 +70,7 @@ public static void setUp() throws Exception {
6970

7071
public static class PagingTest {
7172
@Test
73+
@Ignore("Exception in CI: javax.net.ssl.SSLHandshakeException: PKIX path validation failed: java.security.cert.CertPathValidatorException: validity check failed")
7274
public void duplicatedItemsCheck() throws Exception {
7375
NewPipe.init(DownloaderTestImpl.getInstance());
7476
final SearchExtractor extractor = PeerTube.getSearchExtractor("internet", singletonList(VIDEOS), "");

extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/stream/YoutubeStreamExtractorLivestreamTest.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
package org.schabi.newpipe.extractor.services.youtube.stream;
22

33
import org.junit.BeforeClass;
4+
import org.junit.Ignore;
5+
import org.junit.Test;
46
import org.schabi.newpipe.downloader.DownloaderFactory;
57
import org.schabi.newpipe.extractor.NewPipe;
68
import org.schabi.newpipe.extractor.StreamingService;
@@ -31,6 +33,13 @@ public static void setUp() throws Exception {
3133
extractor.fetchPage();
3234
}
3335

36+
@Override
37+
@Test
38+
@Ignore("When visiting website it shows 'Lofi Girl', unknown why it's different in tests")
39+
public void testUploaderName() throws Exception {
40+
super.testUploaderName();
41+
}
42+
3443
@Override public StreamExtractor extractor() { return extractor; }
3544
@Override public StreamingService expectedService() { return YouTube; }
3645
@Override public String expectedName() { return "lofi hip hop radio - beats to relax/study to"; }
@@ -45,7 +54,7 @@ public static void setUp() throws Exception {
4554
return Arrays.asList("https://bit.ly/chilledcow-playlists",
4655
"https://bit.ly/chilledcow-submissions");
4756
}
48-
@Override public boolean expectedUploaderVerified() { return false; }
57+
@Override public boolean expectedUploaderVerified() { return true; }
4958
@Override public long expectedLength() { return 0; }
5059
@Override public long expectedTimestamp() { return TIMESTAMP; }
5160
@Override public long expectedViewCountAtLeast() { return 0; }

0 commit comments

Comments
 (0)