Skip to content

Commit adcc1f1

Browse files
authored
Merge pull request #1160 from TeamNewPipe/fix/tests
Fix some failing unit tests and detect new account termination messages for YouTube
2 parents 896a55e + 51ddacc commit adcc1f1

14 files changed

Lines changed: 73 additions & 135 deletions

File tree

extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeParsingHelper.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1620,8 +1620,10 @@ public static void defaultAlertsCheck(@Nonnull final JsonObject initialData)
16201620
final String alertText = getTextFromObject(alertRenderer.getObject("text"));
16211621
final String alertType = alertRenderer.getString("type", "");
16221622
if (alertType.equalsIgnoreCase("ERROR")) {
1623-
if (alertText != null && alertText.contains("This account has been terminated")) {
1624-
if (alertText.contains("violation") || alertText.contains("violating")
1623+
if (alertText != null
1624+
&& (alertText.contains("This account has been terminated")
1625+
|| alertText.contains("This channel was removed"))) {
1626+
if (alertText.matches(".*violat(ed|ion|ing).*")
16251627
|| alertText.contains("infringement")) {
16261628
// Possible error messages:
16271629
// "This account has been terminated for a violation of YouTube's Terms of
@@ -1643,6 +1645,7 @@ public static void defaultAlertsCheck(@Nonnull final JsonObject initialData)
16431645
// the user posted."
16441646
// "This account has been terminated because it is linked to an account that
16451647
// received multiple third-party claims of copyright infringement."
1648+
// "This channel was removed because it violated our Community Guidelines."
16461649
throw new AccountTerminatedException(alertText,
16471650
AccountTerminatedException.Reason.VIOLATION);
16481651
} else {

extractor/src/test/java/org/schabi/newpipe/extractor/services/peertube/PeertubeCommentsExtractorTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ void testGetComments() throws IOException, ExtractionException {
4848

4949
@Test
5050
void testGetCommentsFromCommentsInfo() throws IOException, ExtractionException {
51-
final String comment = "Thanks for creating such an informative video";
51+
final String comment = "Thanks for this nice video explanation of Peertube!";
5252

5353
final CommentsInfo commentsInfo =
5454
CommentsInfo.getInfo("https://framatube.org/w/kkGMgK9ZtnKfYAgnEtQxbv");

extractor/src/test/java/org/schabi/newpipe/extractor/services/peertube/PeertubeStreamExtractorTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ public void testGetLanguageInformation() throws ParsingException {
8686
@Override public long expectedViewCountAtLeast() { return 38600; }
8787
@Nullable @Override public String expectedUploadDate() { return "2018-10-01 10:52:46.396"; }
8888
@Nullable @Override public String expectedTextualUploadDate() { return "2018-10-01T10:52:46.396Z"; }
89-
@Override public long expectedLikeCountAtLeast() { return 50; }
89+
@Override public long expectedLikeCountAtLeast() { return 20; }
9090
@Override public long expectedDislikeCountAtLeast() { return 0; }
9191
@Override public String expectedHost() { return "framatube.org"; }
9292
@Override public String expectedCategory() { return "Science & Technology"; }

extractor/src/test/java/org/schabi/newpipe/extractor/services/soundcloud/search/SoundcloudSearchExtractorTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ void testIsVerified() throws IOException, ExtractionException {
186186
public static class NoNextPage extends DefaultSearchExtractorTest {
187187

188188
private static SearchExtractor extractor;
189-
private static final String QUERY = "Dan at hor#berlgbd";
189+
private static final String QUERY = "wpghüä";
190190

191191
@BeforeAll
192192
public static void setUp() throws Exception {

extractor/src/test/resources/org/schabi/newpipe/extractor/services/youtube/extractor/channel/notAvailable/generated_mock_0.json

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,10 @@
4141
"same-origin; report-to\u003d\"youtube_main\""
4242
],
4343
"date": [
44-
"Fri, 08 Dec 2023 19:37:57 GMT"
44+
"Wed, 20 Mar 2024 13:58:42 GMT"
4545
],
4646
"expires": [
47-
"Fri, 08 Dec 2023 19:37:57 GMT"
47+
"Wed, 20 Mar 2024 13:58:42 GMT"
4848
],
4949
"origin-trial": [
5050
"AvC9UlR6RDk2crliDsFl66RWLnTbHrDbp+DiY6AYz/PNQ4G4tdUTjrHYr2sghbkhGQAVxb7jaPTHpEVBz0uzQwkAAAB4eyJvcmlnaW4iOiJodHRwczovL3lvdXR1YmUuY29tOjQ0MyIsImZlYXR1cmUiOiJXZWJWaWV3WFJlcXVlc3RlZFdpdGhEZXByZWNhdGlvbiIsImV4cGlyeSI6MTcxOTUzMjc5OSwiaXNTdWJkb21haW4iOnRydWV9"
@@ -62,9 +62,8 @@
6262
"ESF"
6363
],
6464
"set-cookie": [
65-
"YSC\u003d45cg5Fq7qO4; Domain\u003d.youtube.com; Path\u003d/; Secure; HttpOnly; SameSite\u003dnone",
66-
"VISITOR_INFO1_LIVE\u003d; Domain\u003d.youtube.com; Expires\u003dSat, 13-Mar-2021 19:37:57 GMT; Path\u003d/; Secure; HttpOnly; SameSite\u003dnone",
67-
"CONSENT\u003dPENDING+095; expires\u003dSun, 07-Dec-2025 19:37:57 GMT; path\u003d/; domain\u003d.youtube.com; Secure"
65+
"YSC\u003dLzBi9veM9G4; Domain\u003d.youtube.com; Path\u003d/; Secure; HttpOnly; SameSite\u003dnone",
66+
"VISITOR_INFO1_LIVE\u003d; Domain\u003d.youtube.com; Expires\u003dThu, 24-Jun-2021 13:58:42 GMT; Path\u003d/; Secure; HttpOnly; SameSite\u003dnone"
6867
],
6968
"strict-transport-security": [
7069
"max-age\u003d31536000"

extractor/src/test/resources/org/schabi/newpipe/extractor/services/youtube/extractor/channel/notAvailable/generated_mock_1.json

Lines changed: 6 additions & 7 deletions
Large diffs are not rendered by default.

extractor/src/test/resources/org/schabi/newpipe/extractor/services/youtube/extractor/channel/notAvailable/generated_mock_2.json

Lines changed: 7 additions & 16 deletions
Large diffs are not rendered by default.

extractor/src/test/resources/org/schabi/newpipe/extractor/services/youtube/extractor/channel/notAvailable/generated_mock_3.json

Lines changed: 7 additions & 16 deletions
Large diffs are not rendered by default.

extractor/src/test/resources/org/schabi/newpipe/extractor/services/youtube/extractor/channel/notAvailable/generated_mock_4.json

Lines changed: 7 additions & 16 deletions
Large diffs are not rendered by default.

extractor/src/test/resources/org/schabi/newpipe/extractor/services/youtube/extractor/channel/notAvailable/generated_mock_5.json

Lines changed: 7 additions & 16 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)