Skip to content

Commit aaf3231

Browse files
committed
[MediaCCC] Fix lambda link handler keeping reference to extractor
This caused problems in NewPipe, because extractors are not serializable, and well, keeping references to them is a bad idea anyway.
1 parent 137e924 commit aaf3231

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

extractor/src/main/java/org/schabi/newpipe/extractor/services/media_ccc/extractors/MediaCCCConferenceExtractor.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,11 @@ public boolean isVerified() {
9595
@Nonnull
9696
@Override
9797
public List<ListLinkHandler> getTabs() throws ParsingException {
98+
// avoid keeping a reference to MediaCCCConferenceExtractor inside the lambda
99+
final JsonObject theConferenceData = conferenceData;
98100
return List.of(new ReadyChannelTabListLinkHandler(getUrl(), getId(), ChannelTabs.VIDEOS,
99101
(service, linkHandler) ->
100-
new MediaCCCChannelTabExtractor(service, linkHandler, conferenceData)));
102+
new MediaCCCChannelTabExtractor(service, linkHandler, theConferenceData)));
101103
}
102104

103105
@Override

0 commit comments

Comments
 (0)