Skip to content

Commit a9594f5

Browse files
authored
Merge pull request #543 from XiangRongLin/unignore1
Unignore and fix some tests
2 parents a28e022 + 05cb22c commit a9594f5

5 files changed

Lines changed: 155 additions & 8 deletions

File tree

extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeChannelExtractorTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package org.schabi.newpipe.extractor.services.youtube;
22

33
import org.junit.BeforeClass;
4-
import org.junit.Ignore;
54
import org.junit.Test;
65
import org.schabi.newpipe.downloader.DownloaderFactory;
76
import org.schabi.newpipe.downloader.DownloaderTestImpl;
@@ -15,6 +14,8 @@
1514

1615
import java.io.IOException;
1716

17+
import static org.hamcrest.CoreMatchers.containsString;
18+
import static org.hamcrest.MatcherAssert.assertThat;
1819
import static org.junit.Assert.assertEquals;
1920
import static org.junit.Assert.assertTrue;
2021
import static org.junit.Assert.fail;
@@ -127,10 +128,9 @@ public void testMoreRelatedItems() throws Exception {
127128
// ChannelExtractor
128129
//////////////////////////////////////////////////////////////////////////*/
129130

130-
@Ignore("TODO fix, character ü makes problems")
131131
@Test
132132
public void testDescription() throws Exception {
133-
assertTrue(extractor.getDescription().contains("Zart im Schmelz und süffig im Abgang. Ungebremster Spieltrieb"));
133+
assertThat(extractor.getDescription(), containsString("Ungebremster Spieltrieb seit 1896."));
134134
}
135135

136136
@Test

extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeCommentsExtractorTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package org.schabi.newpipe.extractor.services.youtube;
22

33
import org.junit.BeforeClass;
4-
import org.junit.Ignore;
54
import org.junit.Test;
65
import org.schabi.newpipe.downloader.DownloaderFactory;
76
import org.schabi.newpipe.extractor.ListExtractor.InfoItemsPage;
@@ -132,7 +131,6 @@ public static void setUp() throws Exception {
132131
}
133132

134133
@Test
135-
@Ignore("TODO fix")
136134
public void testGetCommentsAllData() throws IOException, ExtractionException {
137135
final InfoItemsPage<CommentsInfoItem> comments = extractor.getInitialPage();
138136

extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/search/YoutubeSearchQHTest.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,19 @@
11
package org.schabi.newpipe.extractor.services.youtube.search;
22

3-
import org.junit.Ignore;
43
import org.junit.Test;
54

65
import static java.util.Arrays.asList;
76
import static org.junit.Assert.assertEquals;
87
import static org.schabi.newpipe.extractor.ServiceList.YouTube;
9-
import static org.schabi.newpipe.extractor.services.youtube.linkHandler.YoutubeSearchQueryHandlerFactory.*;
8+
import static org.schabi.newpipe.extractor.services.youtube.linkHandler.YoutubeSearchQueryHandlerFactory.CHANNELS;
9+
import static org.schabi.newpipe.extractor.services.youtube.linkHandler.YoutubeSearchQueryHandlerFactory.MUSIC_SONGS;
10+
import static org.schabi.newpipe.extractor.services.youtube.linkHandler.YoutubeSearchQueryHandlerFactory.PLAYLISTS;
11+
import static org.schabi.newpipe.extractor.services.youtube.linkHandler.YoutubeSearchQueryHandlerFactory.VIDEOS;
1012
import static org.schabi.newpipe.extractor.utils.Utils.EMPTY_STRING;
1113

1214
public class YoutubeSearchQHTest {
1315

1416
@Test
15-
@Ignore("TODO fix")
1617
public void testRegularValues() throws Exception {
1718
assertEquals("https://www.youtube.com/results?search_query=asdf", YouTube.getSearchQHFactory().fromQuery("asdf").getUrl());
1819
assertEquals("https://www.youtube.com/results?search_query=hans", YouTube.getSearchQHFactory().fromQuery("hans").getUrl());

extractor/src/test/resources/org/schabi/newpipe/extractor/services/youtube/extractor/comments/empty/generated_mock_0.json

Lines changed: 68 additions & 0 deletions
Large diffs are not rendered by default.

extractor/src/test/resources/org/schabi/newpipe/extractor/services/youtube/extractor/comments/empty/generated_mock_1.json

Lines changed: 80 additions & 0 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)