Skip to content

Commit a023f08

Browse files
authored
Merge pull request #673 from XiangRongLin/recording_downloader
Remove IPv4 addresses from response during mock recording
2 parents 3966178 + b9549ac commit a023f08

176 files changed

Lines changed: 5307 additions & 5726 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

extractor/src/test/java/org/schabi/newpipe/downloader/RecordingDownloader.java

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,10 @@ class RecordingDownloader extends Downloader {
3939

4040
public final static String FILE_NAME_PREFIX = "generated_mock_";
4141

42+
// From https://stackoverflow.com/a/15875500/13516981
43+
private final static String IP_V4_PATTERN =
44+
"(?:(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\\.){3}(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)";
45+
4246
private int index = 0;
4347
private final String path;
4448

@@ -66,7 +70,15 @@ public RecordingDownloader(final String stringPath) throws IOException {
6670
public Response execute(@Nonnull final Request request) throws IOException,
6771
ReCaptchaException {
6872
final Downloader downloader = DownloaderTestImpl.getInstance();
69-
final Response response = downloader.execute(request);
73+
Response response = downloader.execute(request);
74+
String cleanedResponseBody = response.responseBody().replaceAll(IP_V4_PATTERN, "127.0.0.1");
75+
response = new Response(
76+
response.responseCode(),
77+
response.responseMessage(),
78+
response.responseHeaders(),
79+
cleanedResponseBody,
80+
response.latestUrl()
81+
);
7082

7183
final File outputFile = new File(path + File.separator + FILE_NAME_PREFIX + index
7284
+ ".json");

extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeMixPlaylistExtractorTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,7 @@ public void getStreamCount() {
124124
}
125125
}
126126

127+
@Ignore
127128
public static class MixWithIndex {
128129

129130
private static final String INDEX = "&index=13";

extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/stream/YoutubeStreamExtractorLivestreamTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public void testUploaderName() throws Exception {
5353
@Override public String expectedUploaderName() { return "Lofi Girl"; }
5454
@Override public String expectedUploaderUrl() { return "https://www.youtube.com/channel/UCSJ4gkVC6NrvII8umztf0Ow"; }
5555
@Override public List<String> expectedDescriptionContains() {
56-
return Arrays.asList("https://bit.ly/lofigirl-merch",
56+
return Arrays.asList("https://bit.ly/lofigirI-merch",
5757
"Thank you for listening, I hope you will have a good time here");
5858
}
5959
@Override public boolean expectedUploaderVerified() { return true; }

extractor/src/test/resources/org/schabi/newpipe/extractor/kiosk/generated_mock_0.json

Lines changed: 8 additions & 5 deletions
Large diffs are not rendered by default.

extractor/src/test/resources/org/schabi/newpipe/extractor/kiosk/generated_mock_1.json

Lines changed: 8 additions & 5 deletions
Large diffs are not rendered by default.

extractor/src/test/resources/org/schabi/newpipe/extractor/services/youtube/extractor/channel/VSauce/generated_mock_0.json

Lines changed: 8 additions & 5 deletions
Large diffs are not rendered by default.

extractor/src/test/resources/org/schabi/newpipe/extractor/services/youtube/extractor/channel/VSauce/generated_mock_1.json

Lines changed: 8 additions & 5 deletions
Large diffs are not rendered by default.

extractor/src/test/resources/org/schabi/newpipe/extractor/services/youtube/extractor/channel/VSauce/generated_mock_2.json

Lines changed: 8 additions & 5 deletions
Large diffs are not rendered by default.

extractor/src/test/resources/org/schabi/newpipe/extractor/services/youtube/extractor/channel/VSauce/generated_mock_3.json

Lines changed: 86 additions & 80 deletions
Large diffs are not rendered by default.

extractor/src/test/resources/org/schabi/newpipe/extractor/services/youtube/extractor/channel/captainDisillusion/generated_mock_0.json

Lines changed: 8 additions & 5 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)