Skip to content

Commit 9f76908

Browse files
committed
[YouTube] Move Trending kiosk to kiosk package, add deprecation comment
Trending is still working at the time this commit is made, it has been just removed from the interface. Also remove getInstance method of YoutubeTrendingLinkHandlerFactory to make the INSTANCE static field public, for consistency with other kiosks of the service.
1 parent 21c3aad commit 9f76908

4 files changed

Lines changed: 7 additions & 9 deletions

File tree

extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeService.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
import org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeStreamExtractor;
3636
import org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeSubscriptionExtractor;
3737
import org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeSuggestionExtractor;
38-
import org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeTrendingExtractor;
38+
import org.schabi.newpipe.extractor.services.youtube.extractors.kiosk.YoutubeTrendingExtractor;
3939
import org.schabi.newpipe.extractor.services.youtube.extractors.kiosk.YoutubeLiveExtractor;
4040
import org.schabi.newpipe.extractor.services.youtube.extractors.kiosk.YoutubeTrendingGamingVideosExtractor;
4141
import org.schabi.newpipe.extractor.services.youtube.extractors.kiosk.YoutubeTrendingMoviesAndShowsTrailersExtractor;
@@ -164,7 +164,7 @@ public SuggestionExtractor getSuggestionExtractor() {
164164
@Override
165165
public KioskList getKioskList() throws ExtractionException {
166166
final KioskList list = new KioskList(this);
167-
final ListLinkHandlerFactory trendingLHF = YoutubeTrendingLinkHandlerFactory.getInstance();
167+
final ListLinkHandlerFactory trendingLHF = YoutubeTrendingLinkHandlerFactory.INSTANCE;
168168
final ListLinkHandlerFactory runningLivesLHF =
169169
YoutubeLiveLinkHandlerFactory.INSTANCE;
170170
final ListLinkHandlerFactory trendingPodcastsEpisodesLHF =
@@ -218,6 +218,7 @@ public KioskList getKioskList() throws ExtractionException {
218218
trendingMusicLHF,
219219
YoutubeTrendingMusicLinkHandlerFactory.KIOSK_ID
220220
);
221+
// Deprecated (i.e. removed from the interface of YouTube) since July 21, 2025
221222
list.addKioskEntry(
222223
(streamingService, url, id) -> new YoutubeTrendingExtractor(
223224
YoutubeService.this,

extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeTrendingExtractor.java renamed to extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/kiosk/YoutubeTrendingExtractor.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
* along with NewPipe Extractor. If not, see <https://www.gnu.org/licenses/>.
1919
*/
2020

21-
package org.schabi.newpipe.extractor.services.youtube.extractors;
21+
package org.schabi.newpipe.extractor.services.youtube.extractors.kiosk;
2222

2323
import static org.schabi.newpipe.extractor.services.youtube.YoutubeParsingHelper.getJsonPostResponse;
2424
import static org.schabi.newpipe.extractor.services.youtube.YoutubeParsingHelper.getTextAtKey;
@@ -36,6 +36,7 @@
3636
import org.schabi.newpipe.extractor.kiosk.KioskExtractor;
3737
import org.schabi.newpipe.extractor.linkhandler.ListLinkHandler;
3838
import org.schabi.newpipe.extractor.localization.TimeAgoParser;
39+
import org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeStreamInfoItemExtractor;
3940
import org.schabi.newpipe.extractor.stream.StreamInfoItem;
4041
import org.schabi.newpipe.extractor.stream.StreamInfoItemsCollector;
4142

extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/linkHandler/YoutubeTrendingLinkHandlerFactory.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,16 +33,12 @@
3333

3434
public final class YoutubeTrendingLinkHandlerFactory extends ListLinkHandlerFactory {
3535

36-
private static final YoutubeTrendingLinkHandlerFactory INSTANCE =
36+
public static final YoutubeTrendingLinkHandlerFactory INSTANCE =
3737
new YoutubeTrendingLinkHandlerFactory();
3838

3939
private YoutubeTrendingLinkHandlerFactory() {
4040
}
4141

42-
public static YoutubeTrendingLinkHandlerFactory getInstance() {
43-
return INSTANCE;
44-
}
45-
4642
public String getUrl(final String id,
4743
final List<String> contentFilters,
4844
final String sortFilter)

extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeKioskExtractorTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import org.schabi.newpipe.extractor.exceptions.ParsingException;
1010
import org.schabi.newpipe.extractor.services.BaseListExtractorTest;
1111
import org.schabi.newpipe.extractor.services.DefaultSimpleExtractorTest;
12-
import org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeTrendingExtractor;
12+
import org.schabi.newpipe.extractor.services.youtube.extractors.kiosk.YoutubeTrendingExtractor;
1313

1414
public class YoutubeKioskExtractorTest {
1515

0 commit comments

Comments
 (0)