Skip to content

Commit 76fb9dc

Browse files
AudricVStypox
authored andcommitted
Add UnsupportedOperationException to exceptions which can be thrown by getId and getUrl methods of LinkHandlerFactory and its base implementations
This change advertise to clients that channel tabs' link handler factories can return an UnsupportedOperationException when a tab provided to them is unsupported.
1 parent 946eb9b commit 76fb9dc

3 files changed

Lines changed: 10 additions & 8 deletions

File tree

extractor/src/main/java/org/schabi/newpipe/extractor/linkhandler/LinkHandlerFactory.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,14 @@ public abstract class LinkHandlerFactory {
3131
// To Override
3232
///////////////////////////////////
3333

34-
public abstract String getId(String url) throws ParsingException;
34+
public abstract String getId(String url) throws ParsingException, UnsupportedOperationException;
3535

36-
public abstract String getUrl(String id) throws ParsingException;
36+
public abstract String getUrl(String id) throws ParsingException, UnsupportedOperationException;
3737

3838
public abstract boolean onAcceptUrl(String url) throws ParsingException;
3939

40-
public String getUrl(final String id, final String baseUrl) throws ParsingException {
40+
public String getUrl(final String id, final String baseUrl)
41+
throws ParsingException, UnsupportedOperationException {
4142
return getUrl(id);
4243
}
4344

extractor/src/main/java/org/schabi/newpipe/extractor/linkhandler/ListLinkHandlerFactory.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,13 @@ public abstract class ListLinkHandlerFactory extends LinkHandlerFactory {
1414
///////////////////////////////////
1515

1616
public abstract String getUrl(String id, List<String> contentFilter, String sortFilter)
17-
throws ParsingException;
17+
throws ParsingException, UnsupportedOperationException;
1818

1919
public String getUrl(final String id,
2020
final List<String> contentFilter,
2121
final String sortFilter,
22-
final String baseUrl) throws ParsingException {
22+
final String baseUrl)
23+
throws ParsingException, UnsupportedOperationException {
2324
return getUrl(id, contentFilter, sortFilter);
2425
}
2526

@@ -72,7 +73,7 @@ public ListLinkHandler fromQuery(final String id,
7273
*
7374
* @return the url corresponding to id without any filters applied
7475
*/
75-
public String getUrl(final String id) throws ParsingException {
76+
public String getUrl(final String id) throws ParsingException, UnsupportedOperationException {
7677
return getUrl(id, new ArrayList<>(0), "");
7778
}
7879

extractor/src/main/java/org/schabi/newpipe/extractor/linkhandler/SearchQueryHandlerFactory.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ public abstract class SearchQueryHandlerFactory extends ListLinkHandlerFactory {
1313

1414
@Override
1515
public abstract String getUrl(String query, List<String> contentFilter, String sortFilter)
16-
throws ParsingException;
16+
throws ParsingException, UnsupportedOperationException;
1717

1818
@SuppressWarnings("unused")
1919
public String getSearchString(final String url) {
@@ -25,7 +25,7 @@ public String getSearchString(final String url) {
2525
///////////////////////////////////
2626

2727
@Override
28-
public String getId(final String url) {
28+
public String getId(final String url) throws ParsingException, UnsupportedOperationException {
2929
return getSearchString(url);
3030
}
3131

0 commit comments

Comments
 (0)