Skip to content

Commit 724f669

Browse files
committed
[YouTube] Add tests for handles and user IDs with non ASCII characters support
Unneeded public modifiers in test methods of YoutubeChannelLinkHandlerFactoryTest have been also removed.
1 parent 61ce041 commit 724f669

1 file changed

Lines changed: 8 additions & 3 deletions

File tree

extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeChannelLinkHandlerFactoryTest.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,12 @@ public static void setUp() {
2525
}
2626

2727
@Test
28-
public void acceptUrlTest() throws ParsingException {
28+
void acceptUrlTest() throws ParsingException {
2929
assertTrue(linkHandler.acceptUrl("https://www.youtube.com/user/Gronkh"));
3030
assertTrue(linkHandler.acceptUrl("https://www.youtube.com/user/Netzkino/videos"));
3131

3232
assertTrue(linkHandler.acceptUrl("https://www.youtube.com/c/creatoracademy"));
33+
assertTrue(linkHandler.acceptUrl("https://www.youtube.com/c/%EB%85%B8%EB%A7%88%EB%93%9C%EC%BD%94%EB%8D%94NomadCoders"));
3334

3435
assertTrue(linkHandler.acceptUrl("https://youtube.com/DIMENSI0N"));
3536

@@ -49,6 +50,7 @@ public void acceptUrlTest() throws ParsingException {
4950
assertTrue(linkHandler.acceptUrl("https://invidio.us/channel/UClq42foiSgl7sSpLupnugGA/videos?disable_polymer=1"));
5051
assertTrue(linkHandler.acceptUrl("https://www.youtube.com/watchismo"));
5152

53+
assertTrue(linkHandler.acceptUrl("https://www.youtube.com/@YouTube"));
5254

5355
// do not accept URLs which are not channels
5456
assertFalse(linkHandler.acceptUrl("https://www.youtube.com/watch?v=jZViOEv90dI&t=100"));
@@ -62,14 +64,13 @@ public void acceptUrlTest() throws ParsingException {
6264
}
6365

6466
@Test
65-
public void getIdFromUrl() throws ParsingException {
67+
void getIdFromUrl() throws ParsingException {
6668
assertEquals("user/Gronkh", linkHandler.fromUrl("https://www.youtube.com/user/Gronkh").getId());
6769
assertEquals("user/Netzkino", linkHandler.fromUrl("https://www.youtube.com/user/Netzkino/videos").getId());
6870

6971
assertEquals("channel/UClq42foiSgl7sSpLupnugGA", linkHandler.fromUrl("https://www.youtube.com/channel/UClq42foiSgl7sSpLupnugGA").getId());
7072
assertEquals("channel/UClq42foiSgl7sSpLupnugGA", linkHandler.fromUrl("https://www.youtube.com/channel/UClq42foiSgl7sSpLupnugGA/videos?disable_polymer=1").getId());
7173

72-
7374
assertEquals("user/Gronkh", linkHandler.fromUrl("https://hooktube.com/user/Gronkh").getId());
7475
assertEquals("user/Netzkino", linkHandler.fromUrl("https://hooktube.com/user/Netzkino/videos").getId());
7576

@@ -84,5 +85,9 @@ public void getIdFromUrl() throws ParsingException {
8485

8586
assertEquals("c/creatoracademy", linkHandler.fromUrl("https://www.youtube.com/c/creatoracademy").getId());
8687
assertEquals("c/YouTubeCreators", linkHandler.fromUrl("https://www.youtube.com/c/YouTubeCreators").getId());
88+
assertEquals("c/%EB%85%B8%EB%A7%88%EB%93%9C%EC%BD%94%EB%8D%94NomadCoders", linkHandler.fromUrl("https://www.youtube.com/c/%EB%85%B8%EB%A7%88%EB%93%9C%EC%BD%94%EB%8D%94NomadCoders").getId());
89+
90+
assertEquals("@Gronkh", linkHandler.fromUrl("https://www.youtube.com/@Gronkh?ucbcb=1").getId());
91+
assertEquals("@YouTubeCreators", linkHandler.fromUrl("https://www.youtube.com/@YouTubeCreators/shorts").getId());
8792
}
8893
}

0 commit comments

Comments
 (0)