[YouTube] Rewrite manifest test and rename long methods

Author: Stypox

extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeDashManifestCreator.java

@@ -79,7 +79,7 @@ public final class YoutubeDashManifestCreator {
      *
      * <p>
      * This list is automatically cleared in the execution of
-     * {@link #createDashManifestFromOtfStreamingUrl(String, ItagItem, long)}, before the DASH
+     * {@link #fromOtfStreamingUrl(String, ItagItem, long)}, before the DASH
      * manifest is converted to a string.
      * </p>
      */
@@ -90,7 +90,7 @@ public final class YoutubeDashManifestCreator {
      *
      * <p>
      * This list is automatically cleared in the execution of
-     * {@link #createDashManifestFromOtfStreamingUrl(String, ItagItem, long)}, before the DASH
+     * {@link #fromOtfStreamingUrl(String, ItagItem, long)}, before the DASH
      * manifest is converted to a string.
      * </p>
      */
@@ -242,7 +242,7 @@ public static final class YoutubeDashManifestCreationException extends Exception
      *                                              the DASH manifest
      */
     @Nonnull
-    public static String createDashManifestFromOtfStreamingUrl(
+    public static String fromOtfStreamingUrl(
             @Nonnull final String otfBaseStreamingUrl,
             @Nonnull final ItagItem itagItem,
             final long durationSecondsFallback) throws YoutubeDashManifestCreationException {
@@ -376,7 +376,7 @@ public static String createDashManifestFromOtfStreamingUrl(
      *                                              the DASH manifest
      */
     @Nonnull
-    public static String createDashManifestFromPostLiveStreamDvrStreamingUrl(
+    public static String fromPostLiveStreamDvrStreamingUrl(
             @Nonnull final String postLiveStreamDvrStreamingUrl,
             @Nonnull final ItagItem itagItem,
             final int targetDurationSec,
@@ -505,7 +505,7 @@ public static String createDashManifestFromPostLiveStreamDvrStreamingUrl(
      *                                              the DASH manifest
      */
     @Nonnull
-    public static String createDashManifestFromProgressiveStreamingUrl(
+    public static String fromProgressiveStreamingUrl(
             @Nonnull final String progressiveStreamingBaseUrl,
             @Nonnull final ItagItem itagItem,
             final long durationSecondsFallback) throws YoutubeDashManifestCreationException {

extractor/src/test/java/org/schabi/newpipe/extractor/ExtractorAsserts.java

@@ -15,6 +15,8 @@
 import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
+import org.schabi.newpipe.extractor.utils.Utils;
+
 public class ExtractorAsserts {
     public static void assertEmptyErrors(String message, List<Throwable> errors) {
         if (!errors.isEmpty()) {
@@ -64,6 +66,14 @@ public static void assertEmpty(@Nullable String message, String stringToCheck) {
         }
     }
 
+    public static void assertNotBlank(String stringToCheck) {
+        assertNotBlank(stringToCheck, null);
+    }
+
+    public static void assertNotBlank(String stringToCheck, @Nullable String message) {
+        assertFalse(Utils.isBlank(stringToCheck), message);
+    }
+
     public static void assertGreater(final long expected, final long actual) {
         assertGreater(expected, actual, actual + " is not > " + expected);
     }