Skip to content

Commit 58df281

Browse files
committed
Make some fields final
1 parent 89f8678 commit 58df281

13 files changed

Lines changed: 22 additions & 21 deletions

src/main/java/org/schabi/newpipe/extractor/Info.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public abstract class Info implements Serializable {
1616
public final String url;
1717
public final String name;
1818

19-
public List<Throwable> errors = new ArrayList<>();
19+
public final List<Throwable> errors = new ArrayList<>();
2020

2121
public void addError(Throwable throwable) {
2222
this.errors.add(throwable);

src/main/java/org/schabi/newpipe/extractor/Subtitles.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,10 @@
33
import org.schabi.newpipe.extractor.stream.SubtitlesFormat;
44

55
public class Subtitles {
6-
private SubtitlesFormat format;
7-
private String languageCode, URL;
8-
private boolean autoGenerated;
6+
private final SubtitlesFormat format;
7+
private final String languageCode;
8+
private final String URL;
9+
private final boolean autoGenerated;
910

1011
public Subtitles(SubtitlesFormat format, String languageCode, String URL, boolean autoGenerated) {
1112
this.format = format;

src/main/java/org/schabi/newpipe/extractor/SuggestionExtractor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
public abstract class SuggestionExtractor {
2929

30-
private int serviceId;
30+
private final int serviceId;
3131

3232
public SuggestionExtractor(int serviceId) {
3333
this.serviceId = serviceId;

src/main/java/org/schabi/newpipe/extractor/kiosk/KioskExtractor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030

3131
public abstract class KioskExtractor extends ListExtractor {
3232
private String contentCountry = null;
33-
private String id = null;
33+
private final String id;
3434

3535
public KioskExtractor(StreamingService streamingService,
3636
String url,

src/main/java/org/schabi/newpipe/extractor/kiosk/KioskList.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,17 @@ KioskExtractor createNewKiosk(final StreamingService streamingService,
1919
throws ExtractionException, IOException;
2020
}
2121

22-
private int service_id;
23-
private HashMap<String, KioskEntry> kioskList = new HashMap<>();
22+
private final int service_id;
23+
private final HashMap<String, KioskEntry> kioskList = new HashMap<>();
2424
private String defaultKiosk = null;
2525

2626
private class KioskEntry {
2727
public KioskEntry(KioskExtractorFactory ef, UrlIdHandler h) {
2828
extractorFactory = ef;
2929
handler = h;
3030
}
31-
KioskExtractorFactory extractorFactory;
32-
UrlIdHandler handler;
31+
final KioskExtractorFactory extractorFactory;
32+
final UrlIdHandler handler;
3333
}
3434

3535
public KioskList(int service_id) {

src/main/java/org/schabi/newpipe/extractor/search/SearchEngine.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public NothingFoundException(String message) {
3535
}
3636
}
3737

38-
private InfoItemSearchCollector collector;
38+
private final InfoItemSearchCollector collector;
3939

4040
public SearchEngine(int serviceId) {
4141
collector = new InfoItemSearchCollector(serviceId);

src/main/java/org/schabi/newpipe/extractor/services/soundcloud/SoundcloudChannelInfoItemExtractor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import org.schabi.newpipe.extractor.channel.ChannelInfoItemExtractor;
55

66
public class SoundcloudChannelInfoItemExtractor implements ChannelInfoItemExtractor {
7-
private JsonObject searchResult;
7+
private final JsonObject searchResult;
88

99
public SoundcloudChannelInfoItemExtractor(JsonObject searchResult) {
1010
this.searchResult = searchResult;

src/main/java/org/schabi/newpipe/extractor/services/soundcloud/SoundcloudPlaylistInfoItemExtractor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ public class SoundcloudPlaylistInfoItemExtractor implements PlaylistInfoItemExtr
99
private static final String AVATAR_URL_KEY = "avatar_url";
1010
private static final String ARTWORK_URL_KEY = "artwork_url";
1111

12-
private JsonObject searchResult;
12+
private final JsonObject searchResult;
1313

1414
public SoundcloudPlaylistInfoItemExtractor(JsonObject searchResult) {
1515
this.searchResult = searchResult;

src/main/java/org/schabi/newpipe/extractor/services/youtube/ItagItem.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,8 @@ public MediaFormat getMediaFormat() {
146146
return mediaFormat;
147147
}
148148

149-
public int id;
150-
public ItagType itagType;
149+
public final int id;
150+
public final ItagType itagType;
151151

152152
// Audio fields
153153
public int avgBitrate = -1;

src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeChannelInfoItemExtractor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
*/
2727

2828
public class YoutubeChannelInfoItemExtractor implements ChannelInfoItemExtractor {
29-
private Element el;
29+
private final Element el;
3030

3131
public YoutubeChannelInfoItemExtractor(Element el) {
3232
this.el = el;

0 commit comments

Comments
 (0)