Skip to content

Commit 558a973

Browse files
committed
rename search filters
1 parent 8ee068f commit 558a973

7 files changed

Lines changed: 23 additions & 80 deletions

File tree

extractor/src/main/java/org/schabi/newpipe/extractor/services/soundcloud/SoundcloudSearchQueryHandlerFactory.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public class SoundcloudSearchQueryHandlerFactory extends SearchQueryHandlerFacto
1515
public static final String TRACKS = "tracks";
1616
public static final String USERS = "users";
1717
public static final String PLAYLIST = "playlist";
18-
public static final String ANY = "any";
18+
public static final String ALL = "all";
1919

2020
public static final int ITEMS_PER_PAGE = 10;
2121

@@ -35,7 +35,7 @@ public String getUrl(String id, List<String> contentFilter, String sortFilter) t
3535
case PLAYLIST:
3636
url += "/playlists";
3737
break;
38-
case ANY:
38+
case ALL:
3939
default:
4040
break;
4141
}
@@ -58,7 +58,7 @@ public String getUrl(String id, List<String> contentFilter, String sortFilter) t
5858
@Override
5959
public String[] getAvailableContentFilter() {
6060
return new String[] {
61-
ANY,
61+
ALL,
6262
TRACKS,
6363
USERS,
6464
PLAYLIST};

extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/linkHandler/YoutubeSearchQueryHandlerFactory.java

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@ public class YoutubeSearchQueryHandlerFactory extends SearchQueryHandlerFactory
1111

1212
public static final String CHARSET_UTF_8 = "UTF-8";
1313

14-
public static final String STREAM = "stream";
15-
public static final String CHANNEL = "channel";
16-
public static final String PLAYLIST = "playlist";
17-
public static final String ANY = "any";
14+
public static final String VIDEOS = "videos";
15+
public static final String CHANNELS = "channels";
16+
public static final String PLAYLISTS = "playlists";
17+
public static final String ALL = "all";
1818

1919
public static YoutubeSearchQueryHandlerFactory getInstance() {
2020
return new YoutubeSearchQueryHandlerFactory();
@@ -28,10 +28,10 @@ public String getUrl(String searchString, List<String> contentFilters, String so
2828

2929
if(contentFilters.size() > 0) {
3030
switch (contentFilters.get(0)) {
31-
case STREAM: return url + "&sp=EgIQAVAU";
32-
case CHANNEL: return url + "&sp=EgIQAlAU";
33-
case PLAYLIST: return url + "&sp=EgIQA1AU";
34-
case ANY:
31+
case VIDEOS: return url + "&sp=EgIQAVAU";
32+
case CHANNELS: return url + "&sp=EgIQAlAU";
33+
case PLAYLISTS: return url + "&sp=EgIQA1AU";
34+
case ALL:
3535
default:
3636
}
3737
}
@@ -45,9 +45,9 @@ public String getUrl(String searchString, List<String> contentFilters, String so
4545
@Override
4646
public String[] getAvailableContentFilter() {
4747
return new String[] {
48-
ANY,
49-
STREAM,
50-
CHANNEL,
51-
PLAYLIST};
48+
ALL,
49+
VIDEOS,
50+
CHANNELS,
51+
PLAYLISTS};
5252
}
5353
}

extractor/src/test/java/org/schabi/newpipe/extractor/services/soundcloud/search/SoundcloudSearchExtractorChannelOnlyTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import org.schabi.newpipe.extractor.NewPipe;
99
import org.schabi.newpipe.extractor.channel.ChannelInfoItem;
1010
import org.schabi.newpipe.extractor.services.soundcloud.SoundcloudSearchExtractor;
11+
import org.schabi.newpipe.extractor.services.soundcloud.SoundcloudSearchQueryHandlerFactory;
1112

1213
import static java.util.Arrays.asList;
1314
import static org.junit.Assert.*;
@@ -19,15 +20,15 @@ public class SoundcloudSearchExtractorChannelOnlyTest extends SoundcloudSearchEx
1920
public static void setUpClass() throws Exception {
2021
NewPipe.init(Downloader.getInstance());
2122
extractor = (SoundcloudSearchExtractor) SoundCloud.getSearchExtractor("lill uzi vert",
22-
asList(new String[]{"users"}), null, "de");
23+
asList(SoundcloudSearchQueryHandlerFactory.USERS), null, "de");
2324
extractor.fetchPage();
2425
itemsPage = extractor.getInitialPage();
2526
}
2627

2728
@Test
2829
public void testGetSecondPage() throws Exception {
2930
SoundcloudSearchExtractor secondExtractor = (SoundcloudSearchExtractor) SoundCloud.getSearchExtractor("lill uzi vert",
30-
asList(new String[]{"users"}), null, "de");
31+
asList(SoundcloudSearchQueryHandlerFactory.USERS), null, "de");
3132
ListExtractor.InfoItemsPage<InfoItem> secondPage = secondExtractor.getPage(itemsPage.getNextPageUrl());
3233
assertTrue(Integer.toString(secondPage.getItems().size()),
3334
secondPage.getItems().size() >= 3);

extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeStreamExtractorDonationTest.java

Lines changed: 0 additions & 59 deletions
This file was deleted.

extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeTrendingKioskInfoTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public static void setUp()
4343
throws Exception {
4444
NewPipe.init(Downloader.getInstance());
4545
StreamingService service = YouTube;
46-
LinkHandlerFactory LinkHandlerFactory = service.getKioskList().getUIHFactoryByType("Trending");
46+
LinkHandlerFactory LinkHandlerFactory = service.getKioskList().getListLinkHandlerFactoryByType("Trending");
4747

4848
kioskInfo = KioskInfo.getInfo(YouTube, LinkHandlerFactory.fromId("Trending").getUrl(), null);
4949
}

extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeTrendingLinkHandlerFactoryTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public class YoutubeTrendingLinkHandlerFactoryTest {
4141

4242
@BeforeClass
4343
public static void setUp() throws Exception {
44-
LinkHandlerFactory = YouTube.getKioskList().getUIHFactoryByType("Trending");
44+
LinkHandlerFactory = YouTube.getKioskList().getListLinkHandlerFactoryByType("Trending");
4545
NewPipe.init(Downloader.getInstance());
4646
}
4747

extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/search/YoutubeSearchExtractorChannelOnlyTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import org.schabi.newpipe.extractor.NewPipe;
99
import org.schabi.newpipe.extractor.channel.ChannelInfoItem;
1010
import org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeSearchExtractor;
11+
import org.schabi.newpipe.extractor.services.youtube.linkHandler.YoutubeSearchQueryHandlerFactory;
1112

1213
import static java.util.Arrays.asList;
1314
import static org.junit.Assert.*;
@@ -19,15 +20,15 @@ public class YoutubeSearchExtractorChannelOnlyTest extends YoutubeSearchExtracto
1920
public static void setUpClass() throws Exception {
2021
NewPipe.init(Downloader.getInstance());
2122
extractor = (YoutubeSearchExtractor) YouTube.getSearchExtractor("pewdiepie",
22-
asList(new String[]{"channel"}), null, "de");
23+
asList(YoutubeSearchQueryHandlerFactory.CHANNELS), null, "de");
2324
extractor.fetchPage();
2425
itemsPage = extractor.getInitialPage();
2526
}
2627

2728
@Test
2829
public void testGetSecondPage() throws Exception {
2930
YoutubeSearchExtractor secondExtractor = (YoutubeSearchExtractor) YouTube.getSearchExtractor("pewdiepie",
30-
asList(new String[]{"channel"}), null, "de");
31+
asList(YoutubeSearchQueryHandlerFactory.CHANNELS), null, "de");
3132
ListExtractor.InfoItemsPage<InfoItem> secondPage = secondExtractor.getPage(itemsPage.getNextPageUrl());
3233
assertTrue(Integer.toString(secondPage.getItems().size()),
3334
secondPage.getItems().size() > 10);

0 commit comments

Comments
 (0)