Skip to content

Commit 542867f

Browse files
committed
Add documentation for faulty framesets
1 parent 6e3a4a6 commit 542867f

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1377,6 +1377,11 @@ private ItagInfo buildAndAddItagInfoToList(
13771377
return itagInfo;
13781378
}
13791379

1380+
// Warning: When using this method be aware that the YouTube API very rarely returns framesets,
1381+
// that are slightly too small e.g. framesPerPageX = 5, frameWidth = 160, but the url contains
1382+
// a storyboard that is only 795 pixels wide (5*160 > 795). You will need to handle this
1383+
// "manually" to avoid errors.
1384+
// For further reference see: https://github.com/TeamNewPipe/NewPipe/pull/11596
13801385
@Nonnull
13811386
@Override
13821387
public List<Frameset> getFrames() throws ExtractionException {

0 commit comments

Comments
 (0)