Skip to content

Commit 5115541

Browse files
committed
fix peertube trending, added most-liked kiosk
1 parent 6a7680c commit 5115541

5 files changed

Lines changed: 17 additions & 7 deletions

File tree

extractor/src/main/java/org/schabi/newpipe/extractor/services/peertube/PeertubeService.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,7 @@ public KioskExtractor createNewKiosk(StreamingService streamingService,
145145
final PeertubeTrendingLinkHandlerFactory h = new PeertubeTrendingLinkHandlerFactory();
146146
try {
147147
list.addKioskEntry(kioskFactory, h, PeertubeTrendingLinkHandlerFactory.KIOSK_TRENDING);
148+
list.addKioskEntry(kioskFactory, h, PeertubeTrendingLinkHandlerFactory.KIOSK_MOST_LIKED);
148149
list.addKioskEntry(kioskFactory, h, PeertubeTrendingLinkHandlerFactory.KIOSK_RECENT);
149150
list.addKioskEntry(kioskFactory, h, PeertubeTrendingLinkHandlerFactory.KIOSK_LOCAL);
150151
list.setDefaultKiosk(PeertubeTrendingLinkHandlerFactory.KIOSK_TRENDING);

extractor/src/main/java/org/schabi/newpipe/extractor/services/peertube/extractors/PeertubeTrendingExtractor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
import com.grack.nanojson.JsonObject;
2121
import com.grack.nanojson.JsonParser;
2222

23-
public class PeertubeTrendingExtractor extends KioskExtractor {
23+
public class PeertubeTrendingExtractor extends KioskExtractor<StreamInfoItem> {
2424

2525
private static final String START_KEY = "start";
2626
private static final String COUNT_KEY = "count";

extractor/src/main/java/org/schabi/newpipe/extractor/services/peertube/linkHandler/PeertubeTrendingLinkHandlerFactory.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,16 @@ public class PeertubeTrendingLinkHandlerFactory extends ListLinkHandlerFactory {
1717
public static final Map<String, String> KIOSK_MAP;
1818
public static final Map<String, String> REVERSE_KIOSK_MAP;
1919
public static final String KIOSK_TRENDING = "Trending";
20+
public static final String KIOSK_MOST_LIKED = "Most liked";
2021
public static final String KIOSK_RECENT = "Recently added";
2122
public static final String KIOSK_LOCAL = "Local";
2223

2324
static {
2425
Map<String, String> map = new HashMap<>();
25-
map.put(KIOSK_TRENDING, "%s/api/v1/videos?sort=-views");
26+
map.put(KIOSK_TRENDING, "%s/api/v1/videos?sort=-trending");
27+
map.put(KIOSK_MOST_LIKED, "%s/api/v1/videos?sort=-likes");
2628
map.put(KIOSK_RECENT, "%s/api/v1/videos?sort=-publishedAt");
27-
map.put(KIOSK_LOCAL, "%s/api/v1/videos?filter=local");
29+
map.put(KIOSK_LOCAL, "%s/api/v1/videos?sort=-publishedAt&filter=local");
2830
KIOSK_MAP = Collections.unmodifiableMap(map);
2931

3032
Map<String, String> reverseMap = new HashMap<>();
@@ -55,6 +57,8 @@ public String getId(String url) throws ParsingException {
5557
url = url.replace(baseUrl, "%s");
5658
if (url.contains("/videos/trending")) {
5759
return KIOSK_TRENDING;
60+
} else if (url.contains("/videos/most-liked")) {
61+
return KIOSK_MOST_LIKED;
5862
} else if (url.contains("/videos/recently-added")) {
5963
return KIOSK_RECENT;
6064
} else if (url.contains("/videos/local")) {
@@ -68,6 +72,6 @@ public String getId(String url) throws ParsingException {
6872

6973
@Override
7074
public boolean onAcceptUrl(final String url) {
71-
return url.contains("/videos?") || url.contains("/videos/trending") || url.contains("/videos/recently-added") || url.contains("/videos/local");
75+
return url.contains("/videos?") || url.contains("/videos/trending") || url.contains("/videos/most-liked") || url.contains("/videos/recently-added") || url.contains("/videos/local");
7276
}
7377
}

extractor/src/test/java/org/schabi/newpipe/extractor/services/peertube/PeertubeTrendingExtractorTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,6 @@ public void testGetNextPage() throws Exception {
9292

9393
@Test
9494
public void testGetCleanUrl() throws Exception {
95-
assertEquals(extractor.getUrl(), "https://peertube.mastodon.host/api/v1/videos?sort=-views");
95+
assertEquals(extractor.getUrl(), "https://peertube.mastodon.host/api/v1/videos?sort=-trending");
9696
}
9797
}

extractor/src/test/java/org/schabi/newpipe/extractor/services/peertube/PeertubeTrendingLinkHandlerFactoryTest.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,17 @@ public static void setUp() throws Exception {
2929
@Test
3030
public void getUrl()
3131
throws Exception {
32-
assertEquals(LinkHandlerFactory.fromId("Trending").getUrl(), "https://peertube.mastodon.host/api/v1/videos?sort=-views");
32+
assertEquals(LinkHandlerFactory.fromId("Trending").getUrl(), "https://peertube.mastodon.host/api/v1/videos?sort=-trending");
33+
assertEquals(LinkHandlerFactory.fromId("Most liked").getUrl(), "https://peertube.mastodon.host/api/v1/videos?sort=-likes");
3334
assertEquals(LinkHandlerFactory.fromId("Recently added").getUrl(), "https://peertube.mastodon.host/api/v1/videos?sort=-publishedAt");
34-
assertEquals(LinkHandlerFactory.fromId("Local").getUrl(), "https://peertube.mastodon.host/api/v1/videos?filter=local");
35+
assertEquals(LinkHandlerFactory.fromId("Local").getUrl(), "https://peertube.mastodon.host/api/v1/videos?sort=-publishedAt&filter=local");
3536
}
3637

3738
@Test
3839
public void getId()
3940
throws Exception {
4041
assertEquals(LinkHandlerFactory.fromUrl("https://peertube.mastodon.host/videos/trending").getId(), "Trending");
42+
assertEquals(LinkHandlerFactory.fromUrl("https://peertube.mastodon.host/videos/most-liked").getId(), "Most liked");
4143
assertEquals(LinkHandlerFactory.fromUrl("https://peertube.mastodon.host/videos/recently-added").getId(), "Recently added");
4244
assertEquals(LinkHandlerFactory.fromUrl("https://peertube.mastodon.host/videos/local").getId(), "Local");
4345
}
@@ -47,6 +49,9 @@ public void acceptUrl() throws ParsingException {
4749
assertTrue(LinkHandlerFactory.acceptUrl("https://peertube.mastodon.host/videos/trending"));
4850
assertTrue(LinkHandlerFactory.acceptUrl("https://peertube.mastodon.host/videos/trending?adsf=fjaj#fhe"));
4951

52+
assertTrue(LinkHandlerFactory.acceptUrl("https://peertube.mastodon.host/videos/most-liked"));
53+
assertTrue(LinkHandlerFactory.acceptUrl("https://peertube.mastodon.host/videos/most-liked?adsf=fjaj#fhe"));
54+
5055
assertTrue(LinkHandlerFactory.acceptUrl("https://peertube.mastodon.host/videos/recently-added"));
5156
assertTrue(LinkHandlerFactory.acceptUrl("https://peertube.mastodon.host/videos/recently-added?adsf=fjaj#fhe"));
5257

0 commit comments

Comments
 (0)