Skip to content

Commit 4e9e7cb

Browse files
committed
Improve assertTabsContain() to also check size
1 parent 9d0dd36 commit 4e9e7cb

2 files changed

Lines changed: 13 additions & 7 deletions

File tree

extractor/src/test/java/org/schabi/newpipe/extractor/ExtractorAsserts.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,8 +171,17 @@ public static void assertContains(
171171
public static void assertTabsContain(@Nonnull final List<ListLinkHandler> tabs,
172172
@Nonnull final String... expectedTabs) {
173173
final Set<String> tabSet = tabs.stream()
174-
.map(linkHandler -> linkHandler.getContentFilters().get(0))
174+
.map(linkHandler -> {
175+
assertEquals(1, linkHandler.getContentFilters().size(),
176+
"Unexpected content filters for channel tab: "
177+
+ linkHandler.getContentFilters());
178+
return linkHandler.getContentFilters().get(0);
179+
})
175180
.collect(Collectors.toUnmodifiableSet());
181+
182+
assertEquals(expectedTabs.length, tabSet.size(),
183+
"Different amount of tabs returned:\nExpected: "
184+
+ Arrays.toString(expectedTabs) + "\nActual: " + tabSet);
176185
Arrays.stream(expectedTabs)
177186
.forEach(expectedTab -> assertTrue(tabSet.contains(expectedTab),
178187
"Missing " + expectedTab + " tab (got " + tabSet + ")"));

extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeChannelExtractorTest.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -541,7 +541,8 @@ public void testVerified() throws Exception {
541541
@Test
542542
@Override
543543
public void testTabs() throws Exception {
544-
assertTabsContain(extractor.getTabs(), ChannelTabs.VIDEOS, ChannelTabs.PLAYLISTS);
544+
assertTabsContain(extractor.getTabs(),
545+
ChannelTabs.VIDEOS, ChannelTabs.PLAYLISTS, ChannelTabs.SHORTS);
545546
assertTrue(extractor.getTabs().stream()
546547
.filter(it -> ChannelTabs.VIDEOS.equals(it.getContentFilters().get(0)))
547548
.allMatch(ReadyChannelTabListLinkHandler.class::isInstance));
@@ -920,11 +921,7 @@ public void testTabs() throws Exception {
920921
// Gaming topic channels tabs are not yet supported
921922
// However, a Shorts tab like on other channel types is returned, so it is supported
922923
// Check that it is returned
923-
final List<ListLinkHandler> channelTabs = extractor.getTabs();
924-
assertEquals(1, channelTabs.size());
925-
final List<String> contentFilters = channelTabs.get(0).getContentFilters();
926-
assertEquals(1, contentFilters.size());
927-
assertEquals(ChannelTabs.SHORTS, contentFilters.get(0));
924+
assertTabsContain(extractor.getTabs(), ChannelTabs.SHORTS);
928925
}
929926

930927
@Test

0 commit comments

Comments
 (0)