Skip to content

Commit 366ba6f

Browse files
committed
Disable YoutubeMusicSearchExtractor test
"showing results for ..." doesn't seem to be returned by the backend anymore, however the code is still present in the JS frontend.
1 parent e9992bf commit 366ba6f

5 files changed

Lines changed: 10 additions & 1001 deletions

File tree

extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeMusicSearchExtractor.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -149,12 +149,16 @@ public String getSearchSuggestion() throws ParsingException {
149149
for (final JsonObject obj : getItemSectionRendererContents()) {
150150
final JsonObject didYouMeanRenderer = obj
151151
.getObject("didYouMeanRenderer");
152-
final JsonObject showingResultsForRenderer = obj
153-
.getObject("showingResultsForRenderer");
154152

155153
if (!didYouMeanRenderer.isEmpty()) {
156154
return getTextFromObject(didYouMeanRenderer.getObject("correctedQuery"));
157-
} else if (!showingResultsForRenderer.isEmpty()) {
155+
}
156+
157+
// NOTE: As of 2025-07 "showing results for ..." doesn't seem to be returned by
158+
// the backend anymore, however the code is still present in the JS frontend.
159+
final JsonObject showingResultsForRenderer = obj
160+
.getObject("showingResultsForRenderer");
161+
if (!showingResultsForRenderer.isEmpty()) {
158162
return JsonUtils.getString(showingResultsForRenderer,
159163
"correctedQueryEndpoint.searchEndpoint.query");
160164
}

extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/search/YoutubeMusicSearchExtractorTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import static java.util.Collections.singletonList;
55

66
import org.junit.jupiter.api.BeforeAll;
7+
import org.junit.jupiter.api.Disabled;
78
import org.schabi.newpipe.downloader.DownloaderFactory;
89
import org.schabi.newpipe.extractor.InfoItem;
910
import org.schabi.newpipe.extractor.NewPipe;
@@ -143,6 +144,8 @@ public static void setUp() throws Exception {
143144
@Override public InfoItem.InfoType expectedInfoItemType() { return InfoItem.InfoType.CHANNEL; }
144145
}
145146

147+
@Disabled("2025-07 - backend no longer seems to return any suggestion. "
148+
+ "See YoutubeMusicSearchExtractor#getSearchSuggestion")
146149
public static class Suggestion extends DefaultSearchExtractorTest {
147150
private static SearchExtractor extractor;
148151
private static final String QUERY = "megaman x3";

extractor/src/test/resources/org/schabi/newpipe/extractor/services/youtube/extractor/musicSearch/suggestion/generated_mock_0.json

Lines changed: 0 additions & 315 deletions
This file was deleted.

0 commit comments

Comments
 (0)