Skip to content

Commit 33b1121

Browse files
committed
Add tests for parseDurationString()
1 parent bda83fe commit 33b1121

2 files changed

Lines changed: 13 additions & 3 deletions

File tree

extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeParsingHelper.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,10 @@ public static long parseDurationString(String input)
142142
default:
143143
throw new ParsingException("Error duration string with unknown format: " + input);
144144
}
145-
return ((((Long.parseLong(Utils.removeNonDigitCharacters(days)) * 24)
146-
+ Long.parseLong(Utils.removeNonDigitCharacters(hours)) * 60)
147-
+ Long.parseLong(Utils.removeNonDigitCharacters(minutes))) * 60)
145+
146+
return ((Long.parseLong(Utils.removeNonDigitCharacters(days)) * 24
147+
+ Long.parseLong(Utils.removeNonDigitCharacters(hours))) * 60
148+
+ Long.parseLong(Utils.removeNonDigitCharacters(minutes))) * 60
148149
+ Long.parseLong(Utils.removeNonDigitCharacters(seconds));
149150
}
150151

extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeParsingHelperTest.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,11 @@
55
import org.schabi.newpipe.DownloaderTestImpl;
66
import org.schabi.newpipe.extractor.NewPipe;
77
import org.schabi.newpipe.extractor.exceptions.ExtractionException;
8+
import org.schabi.newpipe.extractor.exceptions.ParsingException;
89

910
import java.io.IOException;
1011

12+
import static org.junit.Assert.assertEquals;
1113
import static org.junit.Assert.assertTrue;
1214

1315
public class YoutubeParsingHelperTest {
@@ -27,4 +29,11 @@ public void testAreHardcodedYoutubeMusicKeysValid() throws IOException, Extracti
2729
assertTrue("Hardcoded YouTube Music keys are not valid anymore",
2830
YoutubeParsingHelper.areHardcodedYoutubeMusicKeysValid());
2931
}
32+
33+
@Test
34+
public void testParseDurationString() throws ParsingException {
35+
assertEquals(1162567, YoutubeParsingHelper.parseDurationString("12:34:56:07"));
36+
assertEquals(4445767, YoutubeParsingHelper.parseDurationString("1,234:56:07"));
37+
assertEquals(754, YoutubeParsingHelper.parseDurationString("12:34 "));
38+
}
3039
}

0 commit comments

Comments
 (0)