Improve tests

Author: Isira-Seneviratne

extractor/src/test/java/org/schabi/newpipe/extractor/services/DefaultStreamExtractorTest.java

@@ -16,6 +16,7 @@
 
 import javax.annotation.Nullable;
 import java.time.LocalDateTime;
+import java.time.ZoneId;
 import java.time.format.DateTimeFormatter;
 import java.net.MalformedURLException;
 import java.net.URL;
@@ -200,9 +201,10 @@ public void testUploadDate() throws Exception {
         } else {
             assertNotNull(dateWrapper);
 
-            final LocalDateTime expectedDateTime = LocalDateTime.parse(expectedUploadDate(),
+            final var expectedDateTime = LocalDateTime.parse(expectedUploadDate(),
                     DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss.SSS"));
-            final LocalDateTime actualDateTime = dateWrapper.offsetDateTime().toLocalDateTime();
+            final var actualDateTime = LocalDateTime.ofInstant(dateWrapper.getInstant(),
+                    ZoneId.systemDefault());
 
             assertEquals(expectedDateTime, actualDateTime);
         }

extractor/src/test/java/org/schabi/newpipe/extractor/services/bandcamp/BandcampRadioStreamExtractorTest.java

@@ -19,10 +19,11 @@
 import org.schabi.newpipe.extractor.stream.StreamType;
 
 import java.io.IOException;
-import java.util.Calendar;
+import java.time.LocalDate;
+import java.time.Month;
+import java.time.ZoneOffset;
 import java.util.Collections;
 import java.util.List;
-import java.util.TimeZone;
 
 public class BandcampRadioStreamExtractorTest extends DefaultStreamExtractorTest {
 
@@ -82,14 +83,10 @@ public List<String> expectedDescriptionContains() {
     @Override
     @Test
     public void testUploadDate() throws ParsingException {
-        final Calendar expectedCalendar = Calendar.getInstance();
-
-        // 16 May 2017 00:00:00 GMT
-        expectedCalendar.setTimeZone(TimeZone.getTimeZone("GMT"));
-        expectedCalendar.setTimeInMillis(0);
-        expectedCalendar.set(2017, Calendar.MAY, 16);
-
-        assertEquals(expectedCalendar.getTimeInMillis(), extractor().getUploadDate().offsetDateTime().toInstant().toEpochMilli());
+        final var expectedDate = LocalDate.of(2017, Month.MAY, 16);
+        final var actualDate = LocalDate.ofInstant(extractor().getUploadDate().getInstant(),
+                ZoneOffset.UTC);
+        assertEquals(expectedDate, actualDate);
     }
 
     @Test

extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeChannelLocalizationTest.java

@@ -13,6 +13,8 @@
 import org.schabi.newpipe.extractor.localization.Localization;
 import org.schabi.newpipe.extractor.stream.StreamInfoItem;
 
+import java.time.LocalDateTime;
+import java.time.ZoneId;
 import java.time.format.DateTimeFormatter;
 import java.time.temporal.ChronoUnit;
 import java.util.LinkedHashMap;
@@ -73,7 +75,9 @@ private void testLocalizationsFor(final String channelUrl) throws Exception {
                         + "\n:::: " + item.getStreamType() + ", views = " + item.getViewCount();
                 final DateWrapper uploadDate = item.getUploadDate();
                 if (uploadDate != null) {
-                    final String dateAsText = dateTimeFormatter.format(uploadDate.offsetDateTime());
+                    final var dateTime = LocalDateTime.ofInstant(uploadDate.getInstant(),
+                            ZoneId.systemDefault());
+                    final String dateAsText = dateTimeFormatter.format(dateTime);
                     debugMessage += "\n:::: " + item.getTextualUploadDate() +
                             "\n:::: " + dateAsText;
                 }