Skip to content

Commit 291de18

Browse files
committed
getUIHandler() to getUIHFactory()
handler to handlerFactory in kiosk
1 parent bd5423f commit 291de18

3 files changed

Lines changed: 8 additions & 11 deletions

File tree

extractor/src/main/java/org/schabi/newpipe/extractor/kiosk/KioskList.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@ KioskExtractor createNewKiosk(final StreamingService streamingService,
2525
private class KioskEntry {
2626
public KioskEntry(KioskExtractorFactory ef, UIHFactory h) {
2727
extractorFactory = ef;
28-
handler = h;
28+
handlerFactory = h;
2929
}
3030
final KioskExtractorFactory extractorFactory;
31-
final UIHFactory handler;
31+
final UIHFactory handlerFactory;
3232
}
3333

3434
public KioskList(int service_id) {
@@ -73,7 +73,7 @@ public KioskExtractor getExtractorById(String kioskId, String nextPageUrl)
7373
throw new ExtractionException("No kiosk found with the type: " + kioskId);
7474
} else {
7575
return ke.extractorFactory.createNewKiosk(NewPipe.getService(service_id),
76-
ke.handler.fromId(kioskId).getUrl(), kioskId);
76+
ke.handlerFactory.fromId(kioskId).getUrl(), kioskId);
7777
}
7878
}
7979

@@ -85,14 +85,14 @@ public KioskExtractor getExtractorByUrl(String url, String nextPageUrl)
8585
throws ExtractionException, IOException {
8686
for(Map.Entry<String, KioskEntry> e : kioskList.entrySet()) {
8787
KioskEntry ke = e.getValue();
88-
if(ke.handler.acceptUrl(url)) {
88+
if(ke.handlerFactory.acceptUrl(url)) {
8989
return getExtractorById(e.getKey(), nextPageUrl);
9090
}
9191
}
9292
throw new ExtractionException("Could not find a kiosk that fits to the url: " + url);
9393
}
9494

95-
public UIHFactory getUrlIdHandlerByType(String type) {
96-
return kioskList.get(type).handler;
95+
public UIHFactory getUIHFactoryByType(String type) {
96+
return kioskList.get(type).handlerFactory;
9797
}
9898
}

extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeTrendingKioskInfoTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public static void setUp()
4343
throws Exception {
4444
NewPipe.init(Downloader.getInstance());
4545
StreamingService service = YouTube;
46-
UIHFactory UIHFactory = service.getKioskList().getUrlIdHandlerByType("Trending");
46+
UIHFactory UIHFactory = service.getKioskList().getUIHFactoryByType("Trending");
4747

4848
kioskInfo = KioskInfo.getInfo(YouTube, UIHFactory.fromId("Trending").getUrl(), null);
4949
}

extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeTrendingUIHFactoryTest.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,10 @@
2424
import org.junit.Test;
2525
import org.schabi.newpipe.Downloader;
2626
import org.schabi.newpipe.extractor.NewPipe;
27-
import org.schabi.newpipe.extractor.exceptions.FoundAdException;
2827
import org.schabi.newpipe.extractor.exceptions.ParsingException;
2928
import org.schabi.newpipe.extractor.uih.UIHFactory;
3029
import org.schabi.newpipe.extractor.services.youtube.urlIdHandlers.YoutubeTrendingUIHFactory;
3130

32-
import java.text.ParseException;
33-
3431
import static junit.framework.TestCase.assertFalse;
3532
import static org.junit.Assert.assertEquals;
3633
import static org.junit.Assert.assertTrue;
@@ -44,7 +41,7 @@ public class YoutubeTrendingUIHFactoryTest {
4441

4542
@BeforeClass
4643
public static void setUp() throws Exception {
47-
UIHFactory = YouTube.getKioskList().getUrlIdHandlerByType("Trending");
44+
UIHFactory = YouTube.getKioskList().getUIHFactoryByType("Trending");
4845
NewPipe.init(Downloader.getInstance());
4946
}
5047

0 commit comments

Comments
 (0)