Skip to content

Commit 284362f

Browse files
authored
Merge pull request #608 from TeamNewPipe/youtube-fix-segment-test
[YouTube] fix tests
2 parents dc678a9 + 1fe6457 commit 284362f

11 files changed

Lines changed: 771 additions & 306 deletions

File tree

extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/stream/YoutubeStreamExtractorDefaultTest.java

Lines changed: 29 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -245,59 +245,63 @@ public static void setUp() throws Exception {
245245
// @formatter:on
246246
}
247247

248-
public static class StreamSegmentsTestOstCollection extends DefaultStreamExtractorTest {
248+
public static class StreamSegmentsTestTagesschau extends DefaultStreamExtractorTest {
249249
// StreamSegment example with single macro-makers panel
250-
private static final String ID = "2RYrHwnLHw0";
250+
private static final String ID = "KI7fMGRg0Wk";
251251
private static final String URL = BASE_URL + ID;
252252
private static StreamExtractor extractor;
253253

254254
@BeforeClass
255255
public static void setUp() throws Exception {
256256
YoutubeParsingHelper.resetClientVersionAndKey();
257257
YoutubeParsingHelper.setNumberGenerator(new Random(1));
258-
NewPipe.init(new DownloaderFactory().getDownloader(RESOURCE_PATH + "streamSegmentsOstCollection"));
258+
NewPipe.init(new DownloaderFactory().getDownloader(RESOURCE_PATH + "streamSegmentsTagesschau"));
259259
extractor = YouTube.getStreamExtractor(URL);
260260
extractor.fetchPage();
261261
}
262262

263263
// @formatter:off
264264
@Override public StreamExtractor extractor() { return extractor; }
265265
@Override public StreamingService expectedService() { return YouTube; }
266-
@Override public String expectedName() { return "1 Hour - Most Epic Anime Mix - Battle Anime OST"; }
266+
@Override public String expectedName() { return "tagesschau 20:00 Uhr, 17.03.2021"; }
267267
@Override public String expectedId() { return ID; }
268268
@Override public String expectedUrlContains() { return BASE_URL + ID; }
269269
@Override public String expectedOriginalUrlContains() { return URL; }
270270

271271
@Override public StreamType expectedStreamType() { return StreamType.VIDEO_STREAM; }
272-
@Override public String expectedUploaderName() { return "MathCaires"; }
273-
@Override public String expectedUploaderUrl() { return "https://www.youtube.com/channel/UChFoHg6IT18SCqiwCp_KY7Q"; }
272+
@Override public String expectedUploaderName() { return "tagesschau"; }
273+
@Override public String expectedUploaderUrl() { return "https://www.youtube.com/channel/UC5NOEUbkLheQcaaRldYW5GA"; }
274+
@Override public boolean expectedUploaderVerified() { return true; }
274275
@Override public List<String> expectedDescriptionContains() {
275-
return Arrays.asList("soundtracks", "9:49", "YouSeeBIGGIRLTT");
276+
return Arrays.asList("Themen der Sendung", "07:15", "Wetter", "Sendung nachträglich bearbeitet");
276277
}
277-
@Override public long expectedLength() { return 3889; }
278-
@Override public long expectedViewCountAtLeast() { return 2463261; }
279-
@Nullable @Override public String expectedUploadDate() { return "2019-06-26 00:00:00.000"; }
280-
@Nullable @Override public String expectedTextualUploadDate() { return "2019-06-26"; }
281-
@Override public long expectedLikeCountAtLeast() { return 32100; }
282-
@Override public long expectedDislikeCountAtLeast() { return 750; }
278+
@Override public long expectedLength() { return 953; }
279+
@Override public long expectedViewCountAtLeast() { return 270000; }
280+
@Nullable @Override public String expectedUploadDate() { return "2021-03-17 00:00:00.000"; }
281+
@Nullable @Override public String expectedTextualUploadDate() { return "2021-03-17"; }
282+
@Override public long expectedLikeCountAtLeast() { return 2300; }
283+
@Override public long expectedDislikeCountAtLeast() { return 450; }
283284
@Override public boolean expectedHasSubtitles() { return false; }
284-
@Override public int expectedStreamSegmentsCount() { return 17; }
285+
@Override public int expectedStreamSegmentsCount() { return 13; }
285286
@Override public String expectedLicence() { return YOUTUBE_LICENCE; }
286-
@Override public String expectedCategory() { return "Music"; }
287-
@Override public List<String> expectedTags() {
288-
return Arrays.asList("2019", "2019 anime", "Anime OST", "Epic anime ost", "OST Anime",
289-
"anime epic soundtrack", "armin", "attack on titan", "battle anime ost", "battle anime soundtracks",
290-
"combat anime ost", "epic soundtrack", "eren", "mikasa", "motivational anime ost",
291-
"motivational anime soundtracks", "shingeki no kyojin");
292-
}
287+
@Override public String expectedCategory() { return "News & Politics"; }
293288
// @formatter:on
294289

295290
@Test
296-
public void testStreamSegment() throws Exception {
291+
public void testStreamSegment0() throws Exception {
292+
final StreamSegment segment = extractor.getStreamSegments().get(0);
293+
assertEquals(0, segment.getStartTimeSeconds());
294+
assertEquals("Guten Abend", segment.getTitle());
295+
assertEquals(BASE_URL + ID + "?t=0", segment.getUrl());
296+
assertNotNull(segment.getPreviewUrl());
297+
}
298+
299+
@Test
300+
public void testStreamSegment3() throws Exception {
297301
final StreamSegment segment = extractor.getStreamSegments().get(3);
298-
assertEquals(589, segment.getStartTimeSeconds());
299-
assertEquals("Attack on Titan S2 - YouSeeBIGGIRLTT", segment.getTitle());
300-
assertEquals(BASE_URL + ID + "?t=589", segment.getUrl());
302+
assertEquals(224, segment.getStartTimeSeconds());
303+
assertEquals("Pandemie dämpft Konjunkturprognose für 2021", segment.getTitle());
304+
assertEquals(BASE_URL + ID + "?t=224", segment.getUrl());
301305
assertNotNull(segment.getPreviewUrl());
302306
}
303307
}

extractor/src/test/resources/org/schabi/newpipe/extractor/services/youtube/extractor/search/random/generated_mock_0.json

Lines changed: 4 additions & 4 deletions
Large diffs are not rendered by default.

extractor/src/test/resources/org/schabi/newpipe/extractor/services/youtube/extractor/search/random/generated_mock_1.json

Lines changed: 4 additions & 4 deletions
Large diffs are not rendered by default.

extractor/src/test/resources/org/schabi/newpipe/extractor/services/youtube/extractor/search/random/generated_mock_2.json

Lines changed: 63 additions & 0 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)