Skip to content

Commit 2123b3a

Browse files
committed
Fix search result paging - due to the way as the InfoItemsSearchCollector are re-used,
the returned item list just grows, which cause that same videos are returned.
1 parent 0a3422a commit 2123b3a

3 files changed

Lines changed: 3 additions & 0 deletions

File tree

extractor/src/main/java/org/schabi/newpipe/extractor/services/media_ccc/extractors/MediaCCCSearchExtractor.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ public String getSearchSuggestion() throws ParsingException {
4848
@Override
4949
public InfoItemsPage<InfoItem> getInitialPage() throws IOException, ExtractionException {
5050
InfoItemsSearchCollector searchItems = getInfoItemSearchCollector();
51+
searchItems.reset();
5152

5253
if(getLinkHandler().getContentFilters().contains(CONFERENCES)
5354
|| getLinkHandler().getContentFilters().contains(ALL)

extractor/src/main/java/org/schabi/newpipe/extractor/services/soundcloud/SoundcloudSearchExtractor.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ public void onFetchPage(@Nonnull Downloader downloader) throws IOException, Extr
7676

7777
private InfoItemsCollector<InfoItem, InfoItemExtractor> collectItems(JsonArray searchCollection) {
7878
final InfoItemsSearchCollector collector = getInfoItemSearchCollector();
79+
collector.reset();
7980

8081
for (Object result : searchCollection) {
8182
if (!(result instanceof JsonObject)) continue;

extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeSearchExtractor.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ private String getNextPageUrlFromCurrentUrl(String currentUrl)
106106

107107
private InfoItemsSearchCollector collectItems(Document doc) throws NothingFoundException {
108108
InfoItemsSearchCollector collector = getInfoItemSearchCollector();
109+
collector.reset();
109110

110111
Element list = doc.select("ol[class=\"item-section\"]").first();
111112
final TimeAgoParser timeAgoParser = getTimeAgoParser();

0 commit comments

Comments
 (0)