Skip to content

Commit 1697312

Browse files
committed
Use Collections.emptyList() instead of Collections.EMPTY_LIST or new ArrayList()
1 parent 5bf9fdd commit 1697312

4 files changed

Lines changed: 10 additions & 7 deletions

File tree

extractor/src/main/java/org/schabi/newpipe/extractor/linkhandler/ListLinkHandlerFactory.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import org.schabi.newpipe.extractor.utils.Utils;
55

66
import java.util.ArrayList;
7+
import java.util.Collections;
78
import java.util.List;
89

910
public abstract class ListLinkHandlerFactory extends LinkHandlerFactory {
@@ -13,7 +14,7 @@ public abstract class ListLinkHandlerFactory extends LinkHandlerFactory {
1314
///////////////////////////////////
1415

1516
public List<String> getContentFilter(String url) throws ParsingException {
16-
return new ArrayList<>(0);
17+
return Collections.emptyList();
1718
}
1819

1920
public String getSortFilter(String url) throws ParsingException {

extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampRadioStreamExtractor.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import javax.annotation.Nullable;
2121
import java.io.IOException;
2222
import java.util.ArrayList;
23+
import java.util.Collections;
2324
import java.util.List;
2425

2526
import static org.schabi.newpipe.extractor.services.bandcamp.extractors.BandcampExtractorHelper.getImageUrl;
@@ -137,6 +138,6 @@ public String getCategory() {
137138
@Nonnull
138139
@Override
139140
public List<String> getTags() {
140-
return new ArrayList<>();
141+
return Collections.emptyList();
141142
}
142143
}

extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampStreamExtractor.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -211,24 +211,24 @@ public List<AudioStream> getAudioStreams() {
211211

212212
@Override
213213
public List<VideoStream> getVideoStreams() {
214-
return Collections.EMPTY_LIST;
214+
return Collections.emptyList();
215215
}
216216

217217
@Override
218218
public List<VideoStream> getVideoOnlyStreams() {
219-
return Collections.EMPTY_LIST;
219+
return Collections.emptyList();
220220
}
221221

222222
@Nonnull
223223
@Override
224224
public List<SubtitlesStream> getSubtitlesDefault() {
225-
return new ArrayList<>();
225+
return Collections.emptyList();
226226
}
227227

228228
@Nonnull
229229
@Override
230230
public List<SubtitlesStream> getSubtitles(MediaFormat format) {
231-
return new ArrayList<>();
231+
return Collections.emptyList();
232232
}
233233

234234
@Override

extractor/src/main/java/org/schabi/newpipe/extractor/services/bandcamp/extractors/BandcampSuggestionExtractor.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import java.io.IOException;
1616
import java.net.URLEncoder;
1717
import java.util.ArrayList;
18+
import java.util.Collections;
1819
import java.util.List;
1920

2021
public class BandcampSuggestionExtractor extends SuggestionExtractor {
@@ -48,7 +49,7 @@ public List<String> suggestionList(final String query) throws IOException, Extra
4849
} catch (final JsonParserException e) {
4950
e.printStackTrace();
5051

51-
return new ArrayList<>();
52+
return Collections.emptyList();
5253
}
5354

5455

0 commit comments

Comments
 (0)