Skip to content

Commit 1414a6f

Browse files
authored
Fix extraction of YouTube chapters (#531)
YouTube changed the name of the chapters in the JSON from engagement-panel-macro-markers to engagement-panel-macro-markers-description-chapters, so extracting chapters doesn't work.
1 parent bfa6399 commit 1414a6f

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeStreamExtractor.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1079,8 +1079,10 @@ public List<StreamSegment> getStreamSegments() throws ParsingException {
10791079

10801080
// Search for correct panel containing the data
10811081
for (int i = 0; i < panels.size(); i++) {
1082-
if (panels.getObject(i).getObject("engagementPanelSectionListRenderer")
1083-
.getString("panelIdentifier").equals("engagement-panel-macro-markers")) {
1082+
final String panelIdentifier = panels.getObject(i).getObject("engagementPanelSectionListRenderer")
1083+
.getString("panelIdentifier");
1084+
if (panelIdentifier.equals("engagement-panel-macro-markers-description-chapters")
1085+
|| panelIdentifier.equals("engagement-panel-macro-markers")) {
10841086
segmentsArray = panels.getObject(i).getObject("engagementPanelSectionListRenderer")
10851087
.getObject("content").getObject("macroMarkersListRenderer").getArray("contents");
10861088
break;

extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/stream/YoutubeStreamExtractorDefaultTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,6 @@ public static void setUp() throws Exception {
259259

260260
@Override public int expectedStreamSegmentsCount() { return 7; }
261261
@Test
262-
@Ignore("TODO fix")
263262
public void testStreamSegment() throws Exception {
264263
final StreamSegment segment = extractor.getStreamSegments().get(1);
265264
assertEquals(164, segment.getStartTimeSeconds());

0 commit comments

Comments
 (0)