Skip to content

Commit 0a20c53

Browse files
committed
Use easier-to-read asserts statements in tests
1 parent c921e5d commit 0a20c53

1 file changed

Lines changed: 4 additions & 10 deletions

File tree

extractor/src/test/java/org/schabi/newpipe/extractor/services/DefaultExtractorTest.java

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
import org.schabi.newpipe.extractor.Extractor;
55
import org.schabi.newpipe.extractor.StreamingService;
66

7-
import static org.junit.Assert.assertEquals;
8-
import static org.junit.Assert.assertTrue;
7+
import static org.hamcrest.CoreMatchers.*;
8+
import static org.junit.Assert.*;
99
import static org.schabi.newpipe.extractor.ExtractorAsserts.assertIsSecureUrl;
1010

1111
public abstract class DefaultExtractorTest<T extends Extractor> implements BaseExtractorTest {
@@ -39,21 +39,15 @@ public void testId() throws Exception {
3939
@Override
4040
public void testUrl() throws Exception {
4141
final String url = extractor().getUrl();
42-
final String expectedContains = expectedUrlContains();
43-
4442
assertIsSecureUrl(url);
45-
assertTrue("Url \"" + url + "\" doesn't contains \"" + expectedContains + "\"",
46-
url.contains(expectedContains));
43+
assertThat(url, containsString(expectedUrlContains()));
4744
}
4845

4946
@Test
5047
@Override
5148
public void testOriginalUrl() throws Exception {
5249
final String originalUrl = extractor().getOriginalUrl();
53-
final String expectedContains = expectedOriginalUrlContains();
54-
5550
assertIsSecureUrl(originalUrl);
56-
assertTrue("Original url \"" + originalUrl + "\" doesn't contains \"" + expectedContains + "\"",
57-
originalUrl.contains(expectedContains));
51+
assertThat(originalUrl, containsString(expectedOriginalUrlContains()));
5852
}
5953
}

0 commit comments

Comments
 (0)