fix fetch page

Author: theScrabi

src/main/java/org/schabi/newpipe/extractor/ListExtractor.java

@@ -15,29 +15,10 @@ public abstract class ListExtractor extends Extractor {
 
     /**
      * Get a new ListExtractor with the given nextStreamsUrl set.
-     * <p>
-     * The extractor <b>WILL</b> fetch the page if {@link #fetchPageUponCreation()} return true, otherwise, it will <b>NOT</b>.
-     * <p>
-     * You can call {@link #fetchPage()} later, but this is mainly used just to get more items, so we don't waste bandwidth
-     * downloading the whole page, but if the service that is being implemented need it, just do its own logic in {@link #fetchPageUponCreation()}.
      */
     public ListExtractor(StreamingService service, String url, String nextStreamsUrl) throws IOException, ExtractionException {
         super(service, url);
         setNextStreamsUrl(nextStreamsUrl);
-
-        if (fetchPageUponCreation()) {
-            fetchPage();
-        }
-    }
-
-    /**
-     * Decide if the page will be fetched upon creation.
-     * <p>
-     * The default implementation checks if the nextStreamsUrl is null or empty (indication that the caller
-     * don't need or know what is the next page, thus, fetch the page).
-     */
-    protected boolean fetchPageUponCreation() {
-        return nextStreamsUrl == null || nextStreamsUrl.isEmpty();
     }
 
     @Nonnull

src/main/java/org/schabi/newpipe/extractor/channel/ChannelInfo.java

@@ -55,6 +55,8 @@ public static ChannelInfo getInfo(ServiceList serviceItem, String url) throws IO
     }
 
     public static ChannelInfo getInfo(StreamingService service, String url) throws IOException, ExtractionException {
+        ChannelExtractor extractor = service.getChannelExtractor(url);
+        extractor.fetchPage();
         return getInfo(service.getChannelExtractor(url));
     }
 

src/main/java/org/schabi/newpipe/extractor/kiosk/KioskInfo.java

@@ -65,13 +65,17 @@ public static KioskInfo getInfo(StreamingService service,
                                     String contentCountry) throws IOException, ExtractionException {
         KioskList kl = service.getKioskList();
         KioskExtractor extractor = kl.getExtractorByUrl(url, null);
-        return getInfo(extractor, contentCountry);
-    }
-
-    public static KioskInfo getInfo(KioskExtractor extractor,
-                                    String contentCountry) throws IOException, ExtractionException {
         extractor.setContentCountry(contentCountry);
         extractor.fetchPage();
+        return getInfo(extractor);
+    }
+
+    /**
+     * Get KioskInfo from KioskExtractor
+     *
+     * @param extractor an extractor where fetchPage() was already got called on.
+     */
+    public static KioskInfo getInfo(KioskExtractor extractor) throws ExtractionException {
 
         int serviceId = extractor.getServiceId();
         String name = extractor.getName();

src/main/java/org/schabi/newpipe/extractor/playlist/PlaylistInfo.java

@@ -32,9 +32,16 @@ public static PlaylistInfo getInfo(ServiceList serviceItem, String url) throws I
     }
 
     public static PlaylistInfo getInfo(StreamingService service, String url) throws IOException, ExtractionException {
-        return getInfo(service.getPlaylistExtractor(url));
+        PlaylistExtractor extractor = service.getPlaylistExtractor(url);
+        extractor.fetchPage();
+        return getInfo(extractor);
     }
 
+    /**
+     * Get PlaylistInfo from PlaylistExtractor
+     *
+     * @param extractor an extractor where fetchPage() was already got called on.
+     */
     public static PlaylistInfo getInfo(PlaylistExtractor extractor) throws ParsingException {
 
         int serviceId = extractor.getServiceId();

src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeChannelExtractor.java

@@ -70,14 +70,6 @@ public void onFetchPage(@Nonnull Downloader downloader) throws IOException, Extr
         nextStreamsAjax = null;
     }
 
-    @Override
-    protected boolean fetchPageUponCreation() {
-        // Unfortunately, we have to fetch the page even if we are getting only next streams,
-        // as they don't deliver enough information on their own (the channel name, for example).
-        fetchingNextStreams = nextStreamsUrl != null && !nextStreamsUrl.isEmpty();
-        return true;
-    }
-
     @Nonnull
     @Override
     public String getCleanUrl() {

src/test/java/org/schabi/newpipe/extractor/services/soundcloud/SoundcloudChannelExtractorTest.java

@@ -23,6 +23,7 @@ public static void setUp() throws Exception {
         NewPipe.init(Downloader.getInstance());
         extractor = SoundCloud.getService()
                 .getChannelExtractor("https://soundcloud.com/liluzivert");
+        extractor.fetchPage();
     }
 
     @Test

src/test/java/org/schabi/newpipe/extractor/services/soundcloud/SoundcloudPlaylistExtractorTest.java

@@ -22,6 +22,7 @@ public static void setUp() throws Exception {
         NewPipe.init(Downloader.getInstance());
         extractor = SoundCloud.getService()
                 .getPlaylistExtractor("https://soundcloud.com/liluzivert/sets/the-perfect-luv-tape-r");
+        extractor.fetchPage();
     }
 
     @Test

src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeChannelExtractorTest.java

@@ -44,6 +44,7 @@ public static void setUp() throws Exception {
         NewPipe.init(Downloader.getInstance());
         extractor = (YoutubeChannelExtractor) YouTube.getService()
                 .getChannelExtractor("https://www.youtube.com/user/Gronkh");
+        extractor.fetchPage();
     }
 
     @Test

src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubePlaylistExtractorTest.java

@@ -30,6 +30,7 @@ public static void setUp() throws Exception {
         NewPipe.init(Downloader.getInstance());
         extractor = (YoutubePlaylistExtractor) YouTube.getService()
                 .getPlaylistExtractor("https://www.youtube.com/watch?v=lp-EO5I60KA&list=PLMC9KNkIncKtPzgY-5rmhvj7fax8fdxoj");
+        extractor.fetchPage();
     }
 
     @Test

src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeTrendingExtractorTest.java

@@ -48,6 +48,7 @@ public static void setUp() throws Exception {
         extractor = (YoutubeTrendingExtractor) YouTube.getService()
                 .getKioskList()
                 .getExtractorById("Trending", null);
+        extractor.fetchPage();
     }
 
     @Test