Skip to content

Commit 034f82d

Browse files
committed
[YouTube] Test language and descriptive audio in YoutubeDashManifestCreatorsTest
1 parent 05e8cb3 commit 034f82d

1 file changed

Lines changed: 13 additions & 3 deletions

File tree

extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/YoutubeDashManifestCreatorsTest.java

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import javax.xml.parsers.DocumentBuilderFactory;
2121
import java.io.StringReader;
2222
import java.util.List;
23+
import java.util.Locale;
2324
import java.util.Random;
2425
import java.util.function.Consumer;
2526
import java.util.stream.Collectors;
@@ -191,7 +192,7 @@ private void assertManifestGenerated(final String dashManifest,
191192
() -> assertMpdElement(document),
192193
() -> assertPeriodElement(document),
193194
() -> assertAdaptationSetElement(document, itagItem),
194-
() -> assertRoleElement(document),
195+
() -> assertRoleElement(document, itagItem),
195196
() -> assertRepresentationElement(document, itagItem),
196197
() -> {
197198
if (itagItem.itagType.equals(ItagItem.ItagType.AUDIO)) {
@@ -220,10 +221,19 @@ private void assertAdaptationSetElement(@Nonnull final Document document,
220221
@Nonnull final ItagItem itagItem) {
221222
final Element element = assertGetElement(document, ADAPTATION_SET, PERIOD);
222223
assertAttrEquals(itagItem.getMediaFormat().getMimeType(), element, "mimeType");
224+
225+
if (itagItem.itagType == ItagItem.ItagType.AUDIO) {
226+
final Locale itagAudioLocale = itagItem.getAudioLocale();
227+
if (itagAudioLocale != null) {
228+
assertAttrEquals(itagAudioLocale.getLanguage(), element, "lang");
229+
}
230+
}
223231
}
224232

225-
private void assertRoleElement(@Nonnull final Document document) {
226-
assertGetElement(document, ROLE, ADAPTATION_SET);
233+
private void assertRoleElement(@Nonnull final Document document,
234+
@Nonnull final ItagItem itagItem) {
235+
final Element element = assertGetElement(document, ROLE, ADAPTATION_SET);
236+
assertAttrEquals(itagItem.isDescriptiveAudio() ? "alternate" : "main", element, "value");
227237
}
228238

229239
private void assertRepresentationElement(@Nonnull final Document document,

0 commit comments

Comments
 (0)