Upload Date in StreamInfoItem with Error from PrettyTime Conversion in German

[jonas-skywalker]

Checklist

• I am using the latest version - x.xx.x
• I checked, but didn't find any duplicates (open OR closed) of this issue in the repo.
• I have read the contribution guidelines given at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.
• This issue contains only one bug. I will open one issue for every bug report I want to file.

Steps to reproduce the bug

As the Image shows, if you open any View containing several StreamInfos, some of them have a bad PrettyTime conversion.

Expected behavior

In German (and other languages), the date is expressed with a certain gramatical case. So if the video was made 2 months ago, the date would have to be translated to "vor 2 Monaten". This suffix only appears with the plural of the word so "1 month ago" would translate to "vor 1 Monat" without the n.

Actual behaviour

The upload date is wrongly declinated in a way that it also receives the case suffix if the unit for the date is singular.
"1 month ago" -> "vor 1 Monatn"
This actually only happens with part of the dates as seen in the example picture.

Screenshots/Screen recordings

Logs

No Logs available

Device info

• Android version/Custom ROM version: Android 10
• Device model: Android Emulator (Nexus 5X)

[jonas-skywalker]

I am submitting this issue here because I think this might be related to NewPipe itself because the issue really boils down to the used PrettyTime package. I tested the behaviour myself using only the package and strangely could not reproduce the errror so I am suspecting there could be a bug here. Maybe if somebody has some insight to what could be the problem I would love to fix this issue myself!

[peat80]

Can confirm this behaviour for days too. (1 Tag > 1 Tagn)

[triallax]

My gut tells me this is a PrettyTime issue and not a NewPipe one. In each screenshot posted in this issue, there is a date with one day/month that is shown correctly (first item in both screenshots in fact). I suspect that it might be because it's more than one day but less than two for the other items or something like that?

Edit: I noticed that this issue not applying to all dates was noted before. Silly mistake, but my point is the same.

[triallax]

Also, I am unable to reproduce this issue now. Can you check if it's still present in the latest version (0.21.8)?

[peat80]

Still present here for me on nightly build 233.

[triallax]

I dug a little into PrettyTime's code, and it seems like my hunch was mostly right (I think something like rounding is happening internally here). I'll post what I found on the corresponding issue on PrettyTime's repo.

[triallax]

The corresponding issue on PrettyTime's repo is ocpsoft/prettytime#218.

[ShareASmile]

A PR would be welcome in prettytime repo for solving ocpsoft/prettytime#218 which in turn would solve this bug by using a updated version of the dependency with the fix.

Applied help wanted label to attract contribution for solving this bug.