Add fullscreen default quality option

[TippyLion28]

Checklist

• [/] I checked, but didn't find any duplicates of this issue in the repo.
• [/] I have read the contribution guidelines given at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.
• [/] This issue contains only one feature request. I will open one issue for every feature I want to request.

Describe the feature you want

Now that videos can be played within the information screen seperately from fullscreen, it makes sense to add an option to change the default fullscreen quality independently.

Is your feature request related to a problem? Please describe it

Additional context

How will you/everyone benefit from this feature?

Not really much I can say here other than I think this is a common sense request :-)

[opusforlife2]

Hmmm. Not sure this can be done. The player doesn't change upon rotation.

[TippyLion28]

Maybe keep the current behaviour but add the option to change quality on fullscreen? Same with popup player, quality change could be completely optional :)

[opusforlife2]

That's not an issue with the popup player because it is different from the main player. Rotation, on the other hand, just modifies the main player's dimensions. Anyway, let some developer have a look at this issue. They would know better what to do.

[Stypox]

I think this would ruin the experience: the whole point of having a unified ui was to be able to switch seamlessly between players without having to reload the stream. For example, the stream is kept the same when switching from main to popup, if main was already playing. So changing the quality when pressing fullscreen would just be bad for the user in my opinion. Also note that the difference in bandwidth between 360p (the current default for popups) and 720p60 (the current default for main) is small.

[opusforlife2]

the stream is kept the same when switching from main to popup, if main was already playing

Not if popup has a different default resolution. And even then, I don't think the code recognises that it is the same stream. There is still some delay between switching.

360p (the current default for popups)

480p.

[TippyLion28]

Adding onto this, YouTube in the browser dynamically adjusts quality to match the size of the player when the quality is set to auto. When I fullscreen the player it switches to a higher quality automatically. It does this without any stuttering or delay.

Instead of eagerly blowing away the contents of the buffer, it just begins to buffer higher quality content in a lazy fashion. That way, when the lower quality buffer has been completely consumed, the higher quality video begins seamlessly.

[opusforlife2]

@TippyLion28 Indeed. And for that we first need to implement DASH playback properly. That PR is in the works, and you can look for it.

[TippyLion28]

Awesome, looking forward to that :)

[dftf-stu]

Yeah, more-granular settings like this would be great:

---

When on Wi-Fi:

Default resolution:
720p
Default resolution for pop-up player:
480p
Default resolution for full-screen or vertical-videos:
1080p

---

When on mobile data (or a Wi-Fi network set as metered):

Default resolution:
240p
Default resolution for pop-up player:
144p
Default resolution for full-screen or vertical-videos:
360p