Polish white theme: make app bar text and icons white

[Stypox]

This is how the white theme looks like:

As you can see text and icons in the title bar are black, even though they are on the exact same red background as in the dark theme. Black on red looks strange, so text and icons should be white, as in the Retry button

[IAmSSH]

Hey @Stypox ,
May I work on this bug?
I had a look at the code and I believe that only the LightTheme style in styles.xml needs to be modified to have white color instead of black.
Do mention if I missed something.
Thanks

[Stypox]

I don't think you can just change the color of icons in styles.xml, because some of the icons used in menus are also used in other places. So if you were to change the colors in styles.xml you would get the correct white color in menus, but an invisible icon in other places.
I think what you need to do is force the theme of every toolbar to always be the dark one, by setting the android:theme="@style/..." attribute in toolbar XMLs. Check out this: https://stackoverflow.com/questions/26503149/how-do-i-style-appcompat-v7-toolbar-like-theme-appcompat-light-darkactionbar#26504082

[IAmSSH]

Alright, shall I give it a try then?

[Stypox]

Yeah, go for it, thank you :-)

[IAmSSH]

I changed the theme of the toolbar to DarkTheme to make the toolbar white :

The icons are, however, being styled according to the ones defined in LightTheme.
Shall I replace them with the ones used for DarkTheme?

[Stypox]

Yes

[IAmSSH]

All the changes are done. The app is working fine.
I just wanted to describe the approach I took before submitting a PR.

• Simply changing the theme of the Toolbar to LightTheme did not work. It resulted in some of the text in the app being unreadable.

• I had to create a new ToolbarTheme to apply to Toolbar. It correctly applies text color and contains all icons from the dark theme so that the icons that will be used in the toolbar (eg. share, search etc.) will be fetched from this theme.

• The tabs' icons (eg. What's Hot, Bookmarks etc) were being fetched based on the theme of the app. So, I changed the code, which was responsible for returning the resource id based on theme, to always return the id of resource of white color.

Shall I submit a PR?

[Stypox]

Yes, the steps you have taken seem correct to me, thank you :-D

[IAmSSH]

I have made a PR. Request your review on it.
Thanks.