[Nightly] Streams are not added to history

[TobiGr]

Checklist

• I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
• I made sure that there are no existing issues - open or closed - which I could contribute my information to.
• I have read the FAQ and my problem isn't listed.
• I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
• This issue contains only one bug.
• I have read and understood the contribution guidelines.

Affected version

0.28.1 - nightly @22dfe95

Steps to reproduce the bug

1. Ensure that watch and search history are enabled in the settings
2. Start a stream in background mode which was never started before
3. wait a few seconds
4. open history fragement (either via drawer or as main page tab)
5. skip to next stream in queue

Expected behavior

Streams show up in watch history

Actual behavior

Stream are not added to the watch history

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

mulitple (API 36, 32)

Affected device model

No response

Additional information

Might be related: #12746

[TobiGr]

@theimpulson My first guess is that this is related to the db changes in #12746, could you track this down and see if this is reproducible before the PR was merged?

[branexis]

I've noticed when building refactor and dev branches that videos weren't added to history at all.

It seems that streamHistoryTable.getLatestEntry in onViewed in HistoryRecordManager.java throws error when query returns no records, because getLatestEntry is defined with non-nullable return type. This error is then swallowed by onErrorComplete in registerStreamViewed in Player.java
Changing return type to StreamHistoryEntity? appears to fix it.

[TobiGr]

Thank you for investigating!

We need to check why no error report was created.

[theimpulson]

Thanks 5c9ac91 seems to fix the issue. I see all methods calling it are swallowing the error by either logging or ignoring it. I will address that too while at it.