Speed/Tempo use system language for formatting and not app language

[litetex]

Affected version

nightly-2025-07-18 (0.28.0 rc)

Steps to reproduce the bug

Due to some reason the system language - not the app language - is used for formatting the tempo

This problem was not present in 0.27.7:

Situation to reproduce this:

• System language: German (or anything with different format)
• App specific language set via Android: English
• App language set via app: English

[TobiGr]

@litetex Which Android versions are effected by this?
My best guess is that this was caused by #12093

[litetex]

@TobiGr
Android 15

I will have a look into this

[litetex]

Okay nevermind I confused the formats in the versions.
It's actually working as expected now on Android 13+ and was wrong before.

The problem here is that

NewPipe/app/src/main/java/org/schabi/newpipe/player/helper/PlayerHelper.java

Lines 66 to 69 in 32cec6c

	private static final Formatter STRING_FORMATTER =
	new Formatter(STRING_BUILDER, Locale.getDefault());
	private static final NumberFormat SPEED_FORMATTER = new DecimalFormat("0.##x");
	private static final NumberFormat PITCH_FORMATTER = new DecimalFormat("##%");

are using the system locale (before Android 13), while they should use Localization.getAppLocale instead.

So this is a non-critical issue for lower Android versions.

[Stypox]

Fixed by #12470