At random searches are not saved in list

[ElenaXX]

Checklist

• I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
• I made sure that there are no existing issues - open or closed - which I could contribute my information to.
• I have read the FAQ and my problem isn't listed.
• I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
• This issue contains only one bug.
• I have read and understood the contribution guidelines.

Affected version

0.27.6

Steps to reproduce the bug

Can't be easily reproduced. Occurs at random.
Often your search is not saved in the list of current searches.
It happens more frequently when closing NP while a video is playing.

Expected behavior

One should see the last search in the list of recent searches

Actual behavior

At random, the last search is not memorized in the list of current searches

Screenshots/Screen recordings

Not applicable

Logs

Not applicable

Affected Android/Custom ROM version

14

Affected device model

OnePlus 9 pro

Additional information

No response

[Gonzalo44r]

I'm also affected by this issue.
My Android version is 13, on a Xiaomi "Redmi Note 11 Pro", although I don't think that information is relevant.

I could easily reproduce this bug with a clean/default installation of the latest NewPipe Version v0.27.6.

This is what I've noticed:

• Almost no searches are added to the search history, no matter what try. It is just "random".
• When you make a typo, the app shows you a suggestion to correct your typo (sometimes it says Showing results of <correct words>..., and sometimes Did you mean <correct words>?). When you click any of these, it will relaunch the search with the correction, and then that corrected search will be added to the search history, every time.

Hope this helps.

[ElenaXX]

What I hate of this team, to the point of sounding offensive, is their apparent carelessness in fixing the reported bugs. I will never donate as long as I detect this general attitude. To date, the reported bug was not fixed yet, and none of those I reported was. I am sure they didn't even take care of investigating. My grudge is because I am a developer (despite not of fu**ing apps but of professional DSP software), and when an user reports a bug I run checking and fixing it without questioning, being only thankful because users reporting bugs are a precious feedback to improve one's software. And I deserve all the few donations I receive. I won't report any bugs anymore.

I also faced this bug fir a very long time. I have one more way to reproduce it "search (something that wasn't searched yet) -> open channel from results -> press back -> press back" but it is less reproducible than misspelling method.

I am going to try it

EDIT:

Disposable is created in search method and then almost immediately is called startLoading which disposes "all" disposables including our operation of search storing (if it was unlucky enough to not finish before this moment)

[ElenaXX]

Just a further comment. I really can't understand why fixing this bug is so difficult. *It would be enough to save the search keyword to the list of recent searches immediately as soon as one presses the magnifier button or presses enter ! * This is at least how I would do it. Meh

Just a further comment. I really can't understand why fixing this bug is so difficult. *It would be enough to save the search keyword to the list of recent searches immediately as soon as one presses the magnifier button or presses enter ! * This is at least how I would do it. Meh

Did you see a PR above your message? It is exactly how it is "fixed" there but can you answer the questions from there...? Will it be (android) safe or not?

PS: If there is no one who is interested in doing something, it won't be done (generally when you are contributor you can always find what to do). I understand your indignation but...

[ElenaXX]

No very sorry I don't see it. Please understand that most people who report bugs are aren't coders or experts with GitHub but plain users who try to report bugs indeed. Luckily they can still have feelings like indignation cos they are still humans and not AI bots ;) My apologies anyway ;)