Skip to content

Commit fc4dd45

Browse files
committed
Replaced if/else with switch
1 parent c12ac64 commit fc4dd45

1 file changed

Lines changed: 9 additions & 8 deletions

File tree

app/src/main/java/org/schabi/newpipe/error/ErrorActivity.java

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -190,15 +190,16 @@ public boolean onCreateOptionsMenu(final Menu menu) {
190190

191191
@Override
192192
public boolean onOptionsItemSelected(final MenuItem item) {
193-
final int id = item.getItemId();
194-
if (id == android.R.id.home) {
195-
onBackPressed();
196-
} else if (id == R.id.menu_item_share_error) {
197-
ShareUtils.shareText(this, getString(R.string.error_report_title), buildJson());
198-
} else {
199-
return false;
193+
switch (item.getItemId()) {
194+
case R.id.home:
195+
onBackPressed();
196+
return true;
197+
case R.id.menu_item_share_error:
198+
ShareUtils.shareText(this, getString(R.string.error_report_title), buildJson());
199+
return true;
200+
default:
201+
return false;
200202
}
201-
return true;
202203
}
203204

204205
private void openPrivacyPolicyDialog(final Context context, final String action) {

0 commit comments

Comments
 (0)