Fix New streams settings snackbar not being hidden on exiting

Stypox · Stypox · commit fa58a818529f · 2022-04-16T19:01:30.000+02:00
diff --git a/app/src/main/java/org/schabi/newpipe/settings/NotificationsSettingsFragment.kt b/app/src/main/java/org/schabi/newpipe/settings/NotificationsSettingsFragment.kt
@@ -89,9 +89,6 @@ class NotificationsSettingsFragment : BasePreferenceFragment(), OnSharedPreferen
                     show()
                 }
             }
-        } else {
-            notificationWarningSnackbar?.dismiss()
-            notificationWarningSnackbar = null
         }
 
         // (Re-)Create loader
@@ -106,6 +103,9 @@ class NotificationsSettingsFragment : BasePreferenceFragment(), OnSharedPreferen
         loader?.dispose()
         loader = null
 
+        notificationWarningSnackbar?.dismiss()
+        notificationWarningSnackbar = null
+
         super.onPause()
     }
 

Original file line number	Diff line number	Diff line change
`@@ -89,9 +89,6 @@ class NotificationsSettingsFragment : BasePreferenceFragment(), OnSharedPreferen`
`89`	`89`	`show()`
`90`	`90`	`}`
`91`	`91`	`}`
`92`		`- } else {`
`93`		`- notificationWarningSnackbar?.dismiss()`
`94`		`- notificationWarningSnackbar = null`
`95`	`92`	`}`
`96`	`93`
`97`	`94`	`// (Re-)Create loader`
`@@ -106,6 +103,9 @@ class NotificationsSettingsFragment : BasePreferenceFragment(), OnSharedPreferen`
`106`	`103`	`loader?.dispose()`
`107`	`104`	`loader = null`
`108`	`105`
	`106`	`+ notificationWarningSnackbar?.dismiss()`
	`107`	`+ notificationWarningSnackbar = null`
	`108`	`+`
`109`	`109`	`super.onPause()`
`110`	`110`	`}`
`111`	`111`