Skip to content

Commit f9dae90

Browse files
Always show comment thumbnails, even if placeholders
1 parent e955bee commit f9dae90

2 files changed

Lines changed: 23 additions & 27 deletions

File tree

app/src/main/java/org/schabi/newpipe/ui/components/comment/Comment.kt

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -66,22 +66,20 @@ fun Comment(comment: CommentsInfoItem) {
6666
.padding(8.dp),
6767
horizontalArrangement = Arrangement.spacedBy(8.dp)
6868
) {
69-
if (ImageStrategy.shouldLoadImages()) {
70-
AsyncImage(
71-
model = ImageStrategy.choosePreferredImage(comment.uploaderAvatars),
72-
contentDescription = null,
73-
placeholder = painterResource(R.drawable.placeholder_person),
74-
error = painterResource(R.drawable.placeholder_person),
75-
modifier = Modifier
76-
.size(42.dp)
77-
.clip(CircleShape)
78-
.clickable {
79-
NavigationHelper.openCommentAuthorIfPresent(
80-
context as FragmentActivity, comment
81-
)
82-
}
83-
)
84-
}
69+
AsyncImage(
70+
model = ImageStrategy.choosePreferredImage(comment.uploaderAvatars),
71+
contentDescription = null,
72+
placeholder = painterResource(R.drawable.placeholder_person),
73+
error = painterResource(R.drawable.placeholder_person),
74+
modifier = Modifier
75+
.size(42.dp)
76+
.clip(CircleShape)
77+
.clickable {
78+
NavigationHelper.openCommentAuthorIfPresent(
79+
context as FragmentActivity, comment
80+
)
81+
}
82+
)
8583

8684
Column(verticalArrangement = Arrangement.spacedBy(4.dp)) {
8785
Row(horizontalArrangement = Arrangement.spacedBy(4.dp)) {

app/src/main/java/org/schabi/newpipe/ui/components/comment/CommentRepliesHeader.kt

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -51,17 +51,15 @@ fun CommentRepliesHeader(comment: CommentsInfoItem) {
5151
horizontalArrangement = Arrangement.spacedBy(8.dp),
5252
verticalAlignment = Alignment.CenterVertically
5353
) {
54-
if (ImageStrategy.shouldLoadImages()) {
55-
AsyncImage(
56-
model = ImageStrategy.choosePreferredImage(comment.uploaderAvatars),
57-
contentDescription = null,
58-
placeholder = painterResource(R.drawable.placeholder_person),
59-
error = painterResource(R.drawable.placeholder_person),
60-
modifier = Modifier
61-
.size(42.dp)
62-
.clip(CircleShape)
63-
)
64-
}
54+
AsyncImage(
55+
model = ImageStrategy.choosePreferredImage(comment.uploaderAvatars),
56+
contentDescription = null,
57+
placeholder = painterResource(R.drawable.placeholder_person),
58+
error = painterResource(R.drawable.placeholder_person),
59+
modifier = Modifier
60+
.size(42.dp)
61+
.clip(CircleShape)
62+
)
6563

6664
Column {
6765
Text(text = comment.uploaderName)

0 commit comments

Comments
 (0)