Skip to content

Commit ed2967e

Browse files
author
martin
committed
Addressing layout comments
1 parent 616fb47 commit ed2967e

1 file changed

Lines changed: 24 additions & 14 deletions

File tree

app/src/main/res/layout/dialog_playback_parameter.xml

Lines changed: 24 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,8 @@
4848
android:text="--%"
4949
android:textColor="?attr/colorAccent"
5050
android:textStyle="bold"
51-
tools:ignore="HardcodedText"/>
51+
tools:ignore="HardcodedText"
52+
tools:text="-5%" />
5253

5354
<RelativeLayout
5455
android:layout_width="match_parent"
@@ -72,7 +73,8 @@
7273
android:gravity="center"
7374
android:text="-.--x"
7475
android:textColor="?attr/colorAccent"
75-
tools:ignore="HardcodedText"/>
76+
tools:ignore="HardcodedText"
77+
tools:text="1.00x" />
7678

7779
<org.schabi.newpipe.views.NewPipeTextView
7880
android:id="@+id/tempoCurrentText"
@@ -83,7 +85,8 @@
8385
android:text="---%"
8486
android:textColor="?attr/colorAccent"
8587
android:textStyle="bold"
86-
tools:ignore="HardcodedText"/>
88+
tools:ignore="HardcodedText"
89+
tools:text="100%" />
8790

8891
<org.schabi.newpipe.views.NewPipeTextView
8992
android:id="@+id/tempoMaximumText"
@@ -96,7 +99,8 @@
9699
android:gravity="center"
97100
android:text="---%"
98101
android:textColor="?attr/colorAccent"
99-
tools:ignore="HardcodedText"/>
102+
tools:ignore="HardcodedText"
103+
tools:text="300%" />
100104

101105
<androidx.appcompat.widget.AppCompatSeekBar
102106
android:id="@+id/tempoSeekbar"
@@ -124,7 +128,8 @@
124128
android:text="+-%"
125129
android:textColor="?attr/colorAccent"
126130
android:textStyle="bold"
127-
tools:ignore="HardcodedText"/>
131+
tools:ignore="HardcodedText"
132+
tools:text="+5%" />
128133
</RelativeLayout>
129134

130135
<View
@@ -171,7 +176,8 @@
171176
android:text="--%"
172177
android:textColor="?attr/colorAccent"
173178
android:textStyle="bold"
174-
tools:ignore="HardcodedText"/>
179+
tools:ignore="HardcodedText"
180+
tools:text="-5%" />
175181

176182
<RelativeLayout
177183
android:id="@+id/pitchDisplay"
@@ -196,7 +202,8 @@
196202
android:gravity="center"
197203
android:text="---%"
198204
android:textColor="?attr/colorAccent"
199-
tools:ignore="HardcodedText"/>
205+
tools:ignore="HardcodedText"
206+
tools:text="25%" />
200207

201208
<org.schabi.newpipe.views.NewPipeTextView
202209
android:id="@+id/pitchCurrentText"
@@ -207,7 +214,8 @@
207214
android:text="---%"
208215
android:textColor="?attr/colorAccent"
209216
android:textStyle="bold"
210-
tools:ignore="HardcodedText"/>
217+
tools:ignore="HardcodedText"
218+
tools:text="100%" />
211219

212220
<org.schabi.newpipe.views.NewPipeTextView
213221
android:id="@+id/pitchMaximumText"
@@ -220,7 +228,8 @@
220228
android:gravity="center"
221229
android:text="---%"
222230
android:textColor="?attr/colorAccent"
223-
tools:ignore="HardcodedText"/>
231+
tools:ignore="HardcodedText"
232+
tools:text="300%" />
224233

225234
<androidx.appcompat.widget.AppCompatSeekBar
226235
android:id="@+id/pitchSeekbar"
@@ -248,7 +257,8 @@
248257
android:text="+-%"
249258
android:textColor="?attr/colorAccent"
250259
android:textStyle="bold"
251-
tools:ignore="HardcodedText"/>
260+
tools:ignore="HardcodedText"
261+
tools:text="+5%" />
252262
</RelativeLayout>
253263

254264
<RelativeLayout
@@ -274,7 +284,7 @@
274284
android:textColor="?attr/colorAccent"
275285
android:textSize="24sp"
276286
android:textStyle="bold"
277-
tools:ignore="HardcodedText"/>
287+
tools:ignore="HardcodedText" />
278288

279289
<RelativeLayout
280290
android:id="@+id/semitoneDisplay"
@@ -309,7 +319,7 @@
309319
android:gravity="center"
310320
android:textColor="?attr/colorAccent"
311321
android:textStyle="bold"
312-
tools:ignore="HardcodedText"/>
322+
tools:text="0" />
313323

314324
<org.schabi.newpipe.views.NewPipeTextView
315325
android:id="@+id/semitoneMaximumText"
@@ -322,7 +332,7 @@
322332
android:gravity="center"
323333
android:text="+12"
324334
android:textColor="?attr/colorAccent"
325-
tools:ignore="HardcodedText"/>
335+
tools:ignore="HardcodedText" />
326336

327337
<androidx.appcompat.widget.AppCompatSeekBar
328338
android:id="@+id/semitoneSeekbar"
@@ -352,7 +362,7 @@
352362
android:textColor="?attr/colorAccent"
353363
android:textSize="20sp"
354364
android:textStyle="bold"
355-
tools:ignore="HardcodedText"/>
365+
tools:ignore="HardcodedText" />
356366
</RelativeLayout>
357367

358368
<View

0 commit comments

Comments
 (0)