FinishedMIssionStore: Throw exception if column is missing

 ../../src/main/java/us/shandian/giga/get/sqlite/FinishedMissionStore.java:105: Value must be ≥ 0 but getColumnIndex can be -1

Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>

Author: theimpulson

app/src/main/java/us/shandian/giga/get/sqlite/FinishedMissionStore.java

@@ -102,14 +102,23 @@ public void onUpgrade(SQLiteDatabase db, int oldVersion, int newVersion) {
                 db.beginTransaction();
                 while (cursor.moveToNext()) {
                     ContentValues values = new ContentValues();
-                    values.put(KEY_SOURCE, cursor.getString(cursor.getColumnIndex(KEY_SOURCE)));
-                    values.put(KEY_DONE, cursor.getString(cursor.getColumnIndex(KEY_DONE)));
-                    values.put(KEY_TIMESTAMP, cursor.getLong(cursor.getColumnIndex(KEY_TIMESTAMP)));
-                    values.put(KEY_KIND, cursor.getString(cursor.getColumnIndex(KEY_KIND)));
+                    values.put(
+                            KEY_SOURCE,
+                            cursor.getString(cursor.getColumnIndexOrThrow(KEY_SOURCE))
+                    );
+                    values.put(
+                            KEY_DONE,
+                            cursor.getString(cursor.getColumnIndexOrThrow(KEY_DONE))
+                    );
+                    values.put(
+                            KEY_TIMESTAMP,
+                            cursor.getLong(cursor.getColumnIndexOrThrow(KEY_TIMESTAMP))
+                    );
+                    values.put(KEY_KIND, cursor.getString(cursor.getColumnIndexOrThrow(KEY_KIND)));
                     values.put(KEY_PATH, Uri.fromFile(
                             new File(
-                                    cursor.getString(cursor.getColumnIndex(KEY_LOCATION)),
-                                    cursor.getString(cursor.getColumnIndex(KEY_NAME))
+                                    cursor.getString(cursor.getColumnIndexOrThrow(KEY_LOCATION)),
+                                    cursor.getString(cursor.getColumnIndexOrThrow(KEY_NAME))
                             )
                     ).toString());
 
@@ -141,7 +150,8 @@ private ContentValues getValuesOfMission(@NonNull Mission downloadMission) {
     }
 
     private FinishedMission getMissionFromCursor(Cursor cursor) {
-        String kind = Objects.requireNonNull(cursor).getString(cursor.getColumnIndex(KEY_KIND));
+        String kind = Objects.requireNonNull(cursor)
+                .getString(cursor.getColumnIndexOrThrow(KEY_KIND));
         if (kind == null || kind.isEmpty()) kind = "?";
 
         String path = cursor.getString(cursor.getColumnIndexOrThrow(KEY_PATH));