Skip to content

Commit dbcb721

Browse files
committed
Don't warn about rhino class in proguard
Likely related to mozilla/rhino@01a7b20 but I am not completely sure. I tested the app and it works well, so I think that org.mozilla.javascript.JavaToJSONConverters is not used really. This is the full list of errors: Missing class java.beans.BeanDescriptor (referenced from: java.lang.Object org.mozilla.javascript.JavaToJSONConverters.lambda$static$4(java.lang.Object)) Missing class java.beans.BeanInfo (referenced from: java.lang.Object org.mozilla.javascript.JavaToJSONConverters.lambda$static$4(java.lang.Object)) Missing class java.beans.IntrospectionException (referenced from: java.lang.Object org.mozilla.javascript.JavaToJSONConverters.lambda$static$4(java.lang.Object)) Missing class java.beans.Introspector (referenced from: java.lang.Object org.mozilla.javascript.JavaToJSONConverters.lambda$static$4(java.lang.Object)) Missing class java.beans.PropertyDescriptor (referenced from: java.lang.Object org.mozilla.javascript.JavaToJSONConverters.lambda$static$4(java.lang.Object))
1 parent 64a8f65 commit dbcb721

2 files changed

Lines changed: 4 additions & 0 deletions

File tree

app/build.gradle

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,9 @@ android {
5656
resValue "string", "app_name", "NewPipe " + System.getProperty('packageSuffix')
5757
archivesBaseName = 'NewPipe_' + System.getProperty('packageSuffix')
5858
}
59+
applicationIdSuffix ".whatever"
60+
resValue "string", "app_name", "NewPipe whatever"
61+
archivesBaseName = 'NewPipe_whatever'
5962
minifyEnabled true
6063
shrinkResources false // disabled to fix F-Droid's reproducible build
6164
proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'

app/proguard-rules.pro

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
-keep class org.schabi.newpipe.extractor.timeago.patterns.** { *; }
88
-keep class org.mozilla.javascript.** { *; }
99
-keep class org.mozilla.classfile.ClassFileWriter
10+
-dontwarn org.mozilla.javascript.JavaToJSONConverters
1011
-dontwarn org.mozilla.javascript.tools.**
1112

1213
## Rules for ExoPlayer

0 commit comments

Comments
 (0)