Skip to content

Commit db5ed48

Browse files
committed
Fix some sonar warnings and make some smaller improvements
1 parent ac5f991 commit db5ed48

2 files changed

Lines changed: 5 additions & 9 deletions

File tree

app/src/main/java/org/schabi/newpipe/player/PlayQueueActivity.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -585,11 +585,9 @@ private void onPlayModeChanged(final int repeatMode, final boolean shuffled) {
585585
}
586586

587587
private void onPlaybackParameterChanged(@Nullable final PlaybackParameters parameters) {
588-
if (parameters != null) {
589-
if (menu != null && player != null) {
590-
final MenuItem item = menu.findItem(R.id.action_playback_speed);
591-
item.setTitle(formatSpeed(parameters.speed));
592-
}
588+
if (parameters != null && menu != null && player != null) {
589+
final MenuItem item = menu.findItem(R.id.action_playback_speed);
590+
item.setTitle(formatSpeed(parameters.speed));
593591
}
594592
}
595593

app/src/main/java/org/schabi/newpipe/settings/tabs/TabsManager.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,10 +73,8 @@ public void unsetSavedTabsListener() {
7373

7474
private SharedPreferences.OnSharedPreferenceChangeListener getPreferenceChangeListener() {
7575
return (sp, key) -> {
76-
if (savedTabsKey.equals(key)) {
77-
if (savedTabsChangeListener != null) {
78-
savedTabsChangeListener.onTabsChanged();
79-
}
76+
if (savedTabsKey.equals(key) && savedTabsChangeListener != null) {
77+
savedTabsChangeListener.onTabsChanged();
8078
}
8179
};
8280
}

0 commit comments

Comments
 (0)