Skip to content

Commit dab0148

Browse files
authored
Merge pull request #11750 from Isira-Seneviratne/Fix-image-loading
Fix image loading
2 parents c0c08a4 + 137ef3f commit dab0148

4 files changed

Lines changed: 12 additions & 2 deletions

File tree

app/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,7 @@ dependencies {
262262

263263
// Image loading
264264
implementation libs.coil.compose
265+
implementation libs.coil.network.okhttp
265266

266267
// Markdown library for Android
267268
implementation libs.markwon.core

app/src/main/java/org/schabi/newpipe/App.kt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import androidx.core.content.getSystemService
1010
import androidx.preference.PreferenceManager
1111
import coil3.ImageLoader
1212
import coil3.SingletonImageLoader
13+
import coil3.network.okhttp.OkHttpNetworkFetcherFactory
1314
import coil3.request.allowRgb565
1415
import coil3.request.crossfade
1516
import coil3.util.DebugLogger
@@ -123,7 +124,9 @@ open class App :
123124
.logger(if (BuildConfig.DEBUG) DebugLogger() else null)
124125
.allowRgb565(getSystemService<ActivityManager>()!!.isLowRamDevice)
125126
.crossfade(true)
126-
.build()
127+
.components {
128+
add(OkHttpNetworkFetcherFactory(callFactory = DownloaderImpl.getInstance().client))
129+
}.build()
127130

128131
protected open fun getDownloader(): Downloader {
129132
val downloader = DownloaderImpl.init(null)

app/src/main/java/org/schabi/newpipe/DownloaderImpl.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,11 @@ private DownloaderImpl(final OkHttpClient.Builder builder) {
4848
this.mCookies = new HashMap<>();
4949
}
5050

51+
@NonNull
52+
public OkHttpClient getClient() {
53+
return client;
54+
}
55+
5156
/**
5257
* It's recommended to call exactly once in the entire lifetime of the application.
5358
*

gradle/libs.versions.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ auto-service = "1.1.1"
99
bridge = "2.0.2"
1010
cardview = "1.0.0"
1111
checkstyle = "10.12.1"
12-
coil = "3.0.3"
12+
coil = "3.0.4"
1313
constraintlayout = "2.1.4"
1414
core-ktx = "1.12.0"
1515
desugar-jdk-libs-nio = "2.0.4"
@@ -114,6 +114,7 @@ assertj-core = { group = "org.assertj", name = "assertj-core", version.ref = "as
114114
auto-service = { group = "com.google.auto.service", name = "auto-service-annotations", version.ref = "auto-service" }
115115
auto-service-kapt = { group = "com.google.auto.service", name = "auto-service", version.ref = "auto-service" }
116116
coil-compose = { group = "io.coil-kt.coil3", name = 'coil-compose', version.ref = "coil" }
117+
coil-network-okhttp = { group = "io.coil-kt.coil3", name = 'coil-network-okhttp', version.ref = "coil" }
117118
desugar-jdk-libs-nio = { group = "com.android.tools", name = "desugar_jdk_libs_nio", version.ref = "desugar-jdk-libs-nio" }
118119
exoplayer-core = { group = "com.google.android.exoplayer", name = "exoplayer-core", version.ref = "exoplayer" }
119120
exoplayer-dash = { module = "com.google.android.exoplayer:exoplayer-dash", version.ref = "exoplayer" }

0 commit comments

Comments
 (0)