Skip to content

Commit d84114b

Browse files
committed
Player/handleIntent: a few comments
1 parent 4e8c034 commit d84114b

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

app/src/main/java/org/schabi/newpipe/player/Player.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -359,6 +359,7 @@ public void handleIntent(@NonNull final Intent intent) {
359359
final PlayerType oldPlayerType = playerType;
360360
playerType = PlayerType.retrieveFromIntent(intent);
361361
initUIsForCurrentPlayerType();
362+
// TODO: what does the following comment mean? Is that a relict?
362363
// We need to setup audioOnly before super(), see "sourceOf"
363364
isAudioOnly = audioPlayerSelected();
364365

@@ -371,24 +372,26 @@ public void handleIntent(@NonNull final Intent intent) {
371372
playQueue.append(newQueue.getStreams());
372373
return;
373374

374-
// Resolve enqueue next intents
375+
// Resolve enqueue next intents
375376
} else if (intent.getBooleanExtra(ENQUEUE_NEXT, false) && playQueue != null) {
376377
final int currentIndex = playQueue.getIndex();
377378
playQueue.append(newQueue.getStreams());
378379
playQueue.move(playQueue.size() - 1, currentIndex + 1);
379380
return;
380381
}
381382

383+
// initPlayback Parameters
382384
final PlaybackParameters savedParameters = retrievePlaybackParametersFromPrefs(this);
383385
final float playbackSpeed = savedParameters.speed;
384386
final float playbackPitch = savedParameters.pitch;
385387
final boolean playbackSkipSilence = getPrefs().getBoolean(getContext().getString(
386388
R.string.playback_skip_silence_key), getPlaybackSkipSilence());
387-
388-
final boolean samePlayQueue = playQueue != null && playQueue.equalStreamsAndIndex(newQueue);
389389
final int repeatMode = intent.getIntExtra(REPEAT_MODE, getRepeatMode());
390390
final boolean playWhenReady = intent.getBooleanExtra(PLAY_WHEN_READY, true);
391391

392+
// branching parameters for below
393+
final boolean samePlayQueue = playQueue != null && playQueue.equalStreamsAndIndex(newQueue);
394+
392395
/*
393396
* TODO As seen in #7427 this does not work:
394397
* There are 3 situations when playback shouldn't be started from scratch (zero timestamp):

0 commit comments

Comments
 (0)