Skip to content

Commit d3c231a

Browse files
committed
Add accessibility label to show channel details button
1 parent 1cf3111 commit d3c231a

2 files changed

Lines changed: 11 additions & 1 deletion

File tree

app/src/main/java/org/schabi/newpipe/ui/components/menu/LongPressMenu.kt

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -386,6 +386,7 @@ fun LongPressMenuHeader(
386386
modifier = modifier
387387
) {
388388
Row(verticalAlignment = Alignment.CenterVertically) {
389+
// thumbnail and decorations
389390
Box {
390391
if (item.thumbnailUrl != null) {
391392
AsyncImage(
@@ -475,6 +476,7 @@ fun LongPressMenuHeader(
475476
}
476477
}
477478

479+
// title, channel and other textual information
478480
Column(
479481
modifier = Modifier.padding(vertical = 8.dp)
480482
) {
@@ -503,7 +505,14 @@ fun LongPressMenuHeader(
503505
modifier = if (onUploaderClick == null) {
504506
Modifier
505507
} else {
506-
Modifier.clickable(onClick = onUploaderClick)
508+
Modifier.clickable(
509+
onClick = onUploaderClick,
510+
onClickLabel = if (item.uploader != null) {
511+
stringResource(R.string.show_channel_details_for, item.uploader)
512+
} else {
513+
stringResource(R.string.show_channel_details)
514+
}
515+
)
507516
}
508517
.fillMaxWidth()
509518
.fadedMarquee(edgeWidth = 12.dp)

app/src/main/res/values/strings.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -436,6 +436,7 @@
436436
<string name="audio_track">Audio track</string>
437437
<string name="hold_to_append">Hold to enqueue</string>
438438
<string name="show_channel_details">Show channel details</string>
439+
<string name="show_channel_details_for">Show channel details for %s</string>
439440
<string name="enqueue_stream">Enqueue</string>
440441
<string name="enqueued">Enqueued</string>
441442
<string name="enqueue_next_stream">Enqueue next</string>

0 commit comments

Comments
 (0)