Merge pull request #12969 from TeamNewPipe/refactor-merge

Merge dev into refactor

Author: theimpulson

.github/CONTRIBUTING.md

@@ -3,6 +3,19 @@
 NewPipe contribution guidelines
 ===============================
 
+## AI policy
+
+* Using generative AI to develop new features or making larger code changes is generally prohibited. Please refrain from contributions which are heavily depending on AI generated source code because they are usually lacking a fundamental understanding of the overall project structure and thus come with poor quality. However, you are allowed to use gen. AI if you
+  * are aware of the project structure,
+  * ensure that the generated code follows the project structure,
+  * fully understand the generated code, and
+  * review the generated code completely.
+* Using AI to find the root cause of bugs and generating small fixes might be acceptable. However, gen. AI often does not fix the underlying problem but is trying to fix the symptoms. If you are using AI to fix bugs, ensure that the root cause is tackled.
+* The use of AI to generate documentation is allowed. We ask you to thoroughly check the quality of generated documentation – wrong, misleading or uninformative documentation is useless and wastes the reader's time. Ensure that reasoning is documented.
+* Using generative AI to write or fill in PR or issue templates is prohibited. Those texts are often lengthy and miss critical information.
+* PRs and issues that do not follow this AI policy can be closed without further explanation.
+
+
 ## Crash reporting
 
 Report crashes through the **automated crash report system** of NewPipe.

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -26,6 +26,8 @@ body:
           required: true
         - label: "I have read and understood the [contribution guidelines](https://github.com/TeamNewPipe/NewPipe/blob/dev/.github/CONTRIBUTING.md)."
           required: true
+        - label: "I have read and understood the [AI policy](https://github.com/TeamNewPipe/NewPipe/blob/dev/.github/CONTRIBUTING.md#ai-policy). The content of this bug report is not generated by AI."
+          required: true
 
   - type: input
     id: app-version

.github/ISSUE_TEMPLATE/feature_request.yml

@@ -25,6 +25,8 @@ body:
           required: true
         - label: "I have read and understood the [contribution guidelines](https://github.com/TeamNewPipe/NewPipe/blob/dev/.github/CONTRIBUTING.md)."
           required: true
+        - label: "I have read and understood the [AI policy](https://github.com/TeamNewPipe/NewPipe/blob/dev/.github/CONTRIBUTING.md#ai-policy). The content of this request is not generated by AI."
+          required: true
 
 
   - type: textarea

.github/PULL_REQUEST_TEMPLATE.md

@@ -32,3 +32,5 @@ The APK can be found by going to the "Checks" tab below the title. On the left p
 
 #### Due diligence
 - [ ] I read the [contribution guidelines](https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md).
+- [ ] The proposed changes follow the [AI policy](https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md#ai-policy).
+- [ ] I tested the changes using an emulator or a physical device.

app/src/main/java/org/schabi/newpipe/database/subscription/SubscriptionEntity.kt

@@ -55,8 +55,8 @@ data class SubscriptionEntity(
     fun toChannelInfoItem(): ChannelInfoItem {
         return ChannelInfoItem(this.serviceId, this.url, this.name).apply {
             thumbnails = ImageStrategy.dbUrlToImageList(this@SubscriptionEntity.avatarUrl)
-            subscriberCount = this.subscriberCount
-            description = this.description
+            subscriberCount = this@SubscriptionEntity.subscriberCount ?: -1
+            description = this@SubscriptionEntity.description
         }
     }
 

app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.kt

@@ -136,6 +136,7 @@ class VideoDetailFragment :
     // player objects
     private var playQueue: PlayQueue? = null
     @JvmField @State var autoPlayEnabled: Boolean = true
+    @JvmField @State var originalOrientation: Int = ActivityInfo.SCREEN_ORIENTATION_UNSPECIFIED
     private var playerService: PlayerService? = null
     private var player: Player? = null
 
@@ -1730,25 +1731,24 @@ class VideoDetailFragment :
     }
 
     override fun onFullscreenToggleButtonClicked() {
-        // On Android TV screen rotation is not supported
-        // In tablet user experience will be better if screen will not be rotated
-        // from landscape to portrait every time.
-        // Just turn on fullscreen mode in landscape orientation
-        // or portrait & unlocked global orientation
-        val isLandscape = DeviceUtils.isLandscape(requireContext())
-        if (DeviceUtils.isTv(activity) || DeviceUtils.isTablet(activity) &&
-            (!PlayerHelper.globalScreenOrientationLocked(activity) || isLandscape)
-        ) {
-            player!!.UIs().get(MainPlayerUi::class)?.toggleFullscreen()
+        val playerUi: MainPlayerUi = player?.UIs()?.get(MainPlayerUi::class.java) ?: return
+
+        // On tablets and TVs, just toggle fullscreen UI without orientation change.
+        if (DeviceUtils.isTablet(activity) || DeviceUtils.isTv(activity)) {
+            playerUi.toggleFullscreen()
             return
         }
 
-        val newOrientation = if (isLandscape)
-            ActivityInfo.SCREEN_ORIENTATION_PORTRAIT
-        else
-            ActivityInfo.SCREEN_ORIENTATION_SENSOR_LANDSCAPE
-
-        activity.setRequestedOrientation(newOrientation)
+        if (playerUi.isFullscreen) {
+            // EXITING FULLSCREEN
+            playerUi.toggleFullscreen()
+            activity.setRequestedOrientation(originalOrientation)
+        } else {
+            // ENTERING FULLSCREEN
+            originalOrientation = activity.getRequestedOrientation()
+            playerUi.toggleFullscreen()
+            activity.setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_SENSOR_LANDSCAPE)
+        }
     }
 
     /*

app/src/main/java/org/schabi/newpipe/player/Player.java

@@ -391,7 +391,7 @@ public void handleIntent(@NonNull final Intent intent) {
                         return;
                     }
                     final PlayQueueItem newItem = newQueue.getStreams().get(0);
-                    newQueue.enqueueNext(newItem, false);
+                    playQueue.enqueueNext(newItem, false);
                     return;
                 }
 

app/src/main/java/us/shandian/giga/ui/adapter/MissionAdapter.java

@@ -2,6 +2,7 @@
 
 import static android.content.Intent.FLAG_GRANT_PREFIX_URI_PERMISSION;
 import static android.content.Intent.FLAG_GRANT_READ_URI_PERMISSION;
+import static android.content.Intent.createChooser;
 import static us.shandian.giga.get.DownloadMission.ERROR_CONNECT_HOST;
 import static us.shandian.giga.get.DownloadMission.ERROR_FILE_CREATION;
 import static us.shandian.giga.get.DownloadMission.ERROR_HTTP_NO_CONTENT;
@@ -349,11 +350,15 @@ private void viewWithFileProvider(Mission mission) {
         if (BuildConfig.DEBUG)
             Log.v(TAG, "Mime: " + mimeType + " package: " + BuildConfig.APPLICATION_ID + ".provider");
 
-        Intent intent = new Intent(Intent.ACTION_VIEW);
-        intent.setDataAndType(resolveShareableUri(mission), mimeType);
-        intent.addFlags(FLAG_GRANT_READ_URI_PERMISSION);
-        intent.addFlags(FLAG_GRANT_PREFIX_URI_PERMISSION);
-        ShareUtils.openIntentInApp(mContext, intent);
+        Intent viewIntent = new Intent(Intent.ACTION_VIEW);
+        viewIntent.setDataAndType(resolveShareableUri(mission), mimeType);
+        viewIntent.addFlags(FLAG_GRANT_READ_URI_PERMISSION);
+        viewIntent.addFlags(FLAG_GRANT_PREFIX_URI_PERMISSION);
+
+        Intent chooserIntent = createChooser(viewIntent, null);
+        chooserIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK | FLAG_GRANT_READ_URI_PERMISSION);
+
+        ShareUtils.openIntentInApp(mContext, chooserIntent);
     }
 
     private void shareFile(Mission mission) {
@@ -364,8 +369,7 @@ private void shareFile(Mission mission) {
         shareIntent.putExtra(Intent.EXTRA_STREAM, resolveShareableUri(mission));
         shareIntent.addFlags(FLAG_GRANT_READ_URI_PERMISSION);
 
-        final Intent intent = new Intent(Intent.ACTION_CHOOSER);
-        intent.putExtra(Intent.EXTRA_INTENT, shareIntent);
+        final Intent intent = createChooser(shareIntent, null);
         // unneeded to set a title to the chooser on Android P and higher because the system
         // ignores this title on these versions
         if (Build.VERSION.SDK_INT <= Build.VERSION_CODES.O_MR1) {

app/src/main/res/values-bn/strings.xml

@@ -296,7 +296,7 @@
     <string name="clear_queue_confirmation_summary">এক প্লেয়ার থেকে অন্য প্লেয়ারে পরিবর্তন করলে তোমার সারি প্রতিস্থাপিত হতে পারে</string>
     <string name="clear_queue_confirmation_title">কিউ মোছার আগে নিশ্চিত করো</string>
     <string name="notification_actions_at_most_three">কমপ্যাক্ট বিজ্ঞপ্তিতে প্রদর্শন করতে তুমি সর্বাধিক তিনটি ক্রিয়া নির্বাচন করতে পারো!</string>
-    <string name="notification_actions_summary">নিচের প্রতিটি প্রজ্ঞাপন ক্রিয়া সম্পাদনা করো। ডান দিকের চেকবাক্স ব্যবহার করে কম্প্যাক্ট নোটিফিকেশনে দেখানোর জন্য তিনটি পর্যন্ত নির্বাচন করো</string>
+    <string name="notification_actions_summary">নিচের প্রতিটি প্রজ্ঞাপন ক্রিয়া সম্পাদনা করুন । ডান দিকের চেকবাক্স ব্যবহার করে কম্প্যাক্ট নোটিফিকেশনে দেখানোর জন্য তিনটি পর্যন্ত নির্বাচন করুন ।</string>
     <string name="notification_scale_to_square_image_summary">প্রদর্শিত ভিডিও থাম্বনেইল ১৬:৯ থেকে ১:১অনুপাতে পরিবর্তন করো</string>
     <string name="settings_category_feed_title">ফিড</string>
     <string name="overwrite">ওভাররাইট</string>
@@ -627,4 +627,8 @@
     <string name="main_page_content_swipe_remove">ভুক্তি মুছতে ডানে-বামে সরাও</string>
     <string name="loading_stream_details">সম্প্রচার বিষয়ক তথ্য প্রক্রিয়ারত…</string>
     <string name="progressive_load_interval_title">প্লেব্যাক লোড বিরতির আকার</string>
+    <string name="yes">হ্যা</string>
+    <string name="no">না</string>
+    <string name="tab_bookmarks_short">প্লেলিস্ট</string>
+    <string name="ignore_hardware_media_buttons_summary">উদাহরণস্বরূপ, যদি আপনি ভাঙা ফিজিক্যাল বোতাম সহ একটি হেডসেট ব্যবহার করেন তবে এটি কার্যকর</string>
 </resources>

app/src/main/res/values-da/strings.xml

@@ -832,4 +832,11 @@
     <string name="short_billion">%sB</string>
     <string name="delete_file">Slet fil</string>
     <string name="account_terminated_service_provides_reason">Kontoen er blevet lukket\n\n%1$s angiver følgende årsag: %2$s</string>
+    <string name="channel_tab_likes">Likes</string>
+    <string name="migration_info_6_7_title">SoundCloud Top 50-siden fjernet</string>
+    <string name="migration_info_6_7_message">SoundCloud har udfaset de oprindelige Top 50-hitlister. Den tilhørende fane er blevet fjernet fra din hovedside.</string>
+    <string name="migration_info_7_8_title">YouTube kombineret trending fjernet</string>
+    <string name="migration_info_7_8_message">YouTube har udfaset den kombinerede trending-side pr. 21. juli 2025. NewPipe har erstattet standardsiden for trending med trending livestreams.\n\nDu kan også vælge andre trending-sider under \"Indstillinger &gt; Indhold &gt; Indhold på hovedsiden\".</string>
+    <string name="trending_gaming">Gaming-trends</string>
+    <string name="trending_podcasts">Trending podcasts</string>
 </resources>