Skip to content

Commit b8dbb3f

Browse files
committed
Use 64 KiB as the default progressive load interval
This ensures a small value is used by default, solving buffering issues at the beginning of videos
1 parent 9a5decd commit b8dbb3f

3 files changed

Lines changed: 7 additions & 6 deletions

File tree

app/src/main/java/org/schabi/newpipe/player/helper/PlayerHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -426,7 +426,7 @@ public static int getProgressiveLoadIntervalBytes(@NonNull final Context context
426426
context.getString(R.string.progressive_load_interval_key),
427427
context.getString(R.string.progressive_load_interval_default_value));
428428

429-
if (context.getString(R.string.progressive_load_interval_default_value)
429+
if (context.getString(R.string.progressive_load_interval_exoplayer_default_value)
430430
.equals(preferredIntervalBytes)) {
431431
return ProgressiveMediaSource.DEFAULT_LOADING_CHECK_INTERVAL_BYTES;
432432
}

app/src/main/res/values/settings_keys.xml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,20 +56,21 @@
5656
</string-array>
5757

5858
<string name="progressive_load_interval_key">progressive_load_interval</string>
59-
<string name="progressive_load_interval_default_value">default</string>
59+
<string name="progressive_load_interval_default_value">64</string>
60+
<string name="progressive_load_interval_exoplayer_default_value">exoplayer_default</string>
6061
<string-array name="progressive_load_interval_descriptions">
6162
<item>1 KiB</item>
6263
<item>16 KiB</item>
6364
<item>64 KiB</item>
6465
<item>256 KiB</item>
65-
<item>@string/progressive_load_interval_default</item>
66+
<item>@string/progressive_load_interval_exoplayer_default</item>
6667
</string-array>
6768
<string-array name="progressive_load_interval_values">
6869
<item>1</item>
6970
<item>16</item>
70-
<item>64</item>
71+
<item>@string/progressive_load_interval_default_value</item>
7172
<item>256</item>
72-
<item>default</item>
73+
<item>@string/progressive_load_interval_exoplayer_default_value</item>
7374
</string-array>
7475

7576
<string name="minimize_on_exit_key">minimize_on_exit_key</string>

app/src/main/res/values/strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -733,7 +733,7 @@
733733
<string name="on">On</string>
734734
<string name="off">Off</string>
735735
<!-- Progressive Load Interval -->
736-
<string name="progressive_load_interval_default">ExoPlayer default</string>
736+
<string name="progressive_load_interval_exoplayer_default">ExoPlayer default</string>
737737
<!-- New streams notifications -->
738738
<string name="notifications_disabled">Notifications are disabled</string>
739739
<string name="get_notified">Get notified</string>

0 commit comments

Comments
 (0)