Partial revert: fix VideoDetailFragment flickering

Yevhen Babiichuk (DustDFG) · Yevhen Babiichuk (DustDFG) · commit b6c50ccca58d · 2026-02-16T15:16:58.000+02:00
Refacor port of: 5155b24 Look at #13132 for more details
diff --git a/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.kt b/app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.kt
@@ -1339,8 +1339,9 @@ class VideoDetailFragment :
                             bottomSheetBehavior.setState(BottomSheetBehavior.STATE_COLLAPSED)
                         }
                         // Rebound to the service if it was closed via notification or mini player
-                        PlayerHolder.setListener(this@VideoDetailFragment)
-                        PlayerHolder.tryBindIfNeeded(requireContext())
+                        if (!PlayerHolder.isBound) {
+                            PlayerHolder.startService(false, this@VideoDetailFragment)
+                        }
                     }
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -1339,8 +1339,9 @@ class VideoDetailFragment :`
`1339`	`1339`	`bottomSheetBehavior.setState(BottomSheetBehavior.STATE_COLLAPSED)`
`1340`	`1340`	`}`
`1341`	`1341`	`// Rebound to the service if it was closed via notification or mini player`
`1342`		`- PlayerHolder.setListener(this@VideoDetailFragment)`
`1343`		`- PlayerHolder.tryBindIfNeeded(requireContext())`
	`1342`	`+ if (!PlayerHolder.isBound) {`
	`1343`	`+ PlayerHolder.startService(false, this@VideoDetailFragment)`
	`1344`	`+ }`
`1344`	`1345`	`}`
`1345`	`1346`	`}`
`1346`	`1347`	`}`